From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Christian Couder" <christian.couder@gmail.com>,
ふじを <ffjlabo@gmail.com>,
git@vger.kernel.org
Subject: Re: Trailers Containing Underscore or Dot Characters
Date: Mon, 18 Nov 2024 10:07:27 +0900 [thread overview]
Message-ID: <xmqqy11hjqnk.fsf@gitster.g> (raw)
In-Reply-To: <Zzb7aI2C2uh_nwuc@pks.im> (Patrick Steinhardt's message of "Fri, 15 Nov 2024 08:42:37 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> The second thing we should be fixing is that git-interpret-trailers(1)
> allows us to add invalid trailers:
>
> $ touch file
> $ git interpret-trailers --in-place file --trailer 'Valid-trailer: bar'
> $ git interpret-trailers --parse file
> Valid-trailer: bar
> $ git interpret-trailers --in-place file --trailer 'Invalid_trailer: bar'
> $ git interpret-trailers --parse file
> $ cat file
>
> Valid-trailer: bar
> Invalid_trailer: bar:
>
> After the second invocation of git-interpret-trailers(1) it is unable to
> find any trailers anymore due to the bogus format of the second trailer
> line.
A good point.
Thanks.
next prev parent reply other threads:[~2024-11-18 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 7:40 Trailers Containing Underscore or Dot Characters ふじを
2024-11-13 21:57 ` Christian Couder
2024-11-13 22:31 ` Junio C Hamano
2024-11-15 7:42 ` Patrick Steinhardt
2024-11-18 1:07 ` Junio C Hamano [this message]
2024-11-17 19:33 ` [PATCH] Documentation/glossary: describe "trailer" kristofferhaugsbakk
2024-11-18 0:40 ` Junio C Hamano
2024-11-18 7:32 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy11hjqnk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=ffjlabo@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.