From: Junio C Hamano <gitster@pobox.com>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
me@yadavpratyush.com, git@vger.kernel.org
Subject: Re: [PATCH] git-gui - use git-hook, honor core.hooksPath
Date: Mon, 18 Sep 2023 10:53:14 -0700 [thread overview]
Message-ID: <xmqqa5tjl65x.fsf@gitster.g> (raw)
In-Reply-To: <a4765b59-1953-695b-4f5e-686bef0a3a50@gmail.com> (Mark Levedahl's message of "Mon, 18 Sep 2023 12:25:02 -0400")
Mark Levedahl <mlevedahl@gmail.com> writes:
> On 9/18/23 11:58, Junio C Hamano wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>>> + set cmd [concat git hook run --ignore-missing $hook_name -- $args 2>@1]
>>>> + return [_open_stdout_stderr $cmd]
>>> This looks so much nicer than the original code.
>>>
>>> Thank you,
>>> Johannes
>> Yup, looking good.
>
> Thanks. BTW, my commit message at "Furthermore, since v2.36 git
> exposes its hook exection machinery via" needs
>
> s/exection/execution/
>
> Should I resend?
Nah, I'll just fix it up locally before merging.
next prev parent reply other threads:[~2023-09-18 17:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 16:45 BUG: git-gui no longer executes hook scripts Mark Levedahl
2023-09-15 17:00 ` Junio C Hamano
2023-09-15 17:15 ` Junio C Hamano
2023-09-15 23:33 ` Mark Levedahl
2023-09-16 0:35 ` [PATCH] git-gui - re-enable use of " Mark Levedahl
2023-09-16 17:28 ` Junio C Hamano
2023-09-16 21:01 ` [PATCH v2] " Mark Levedahl
2023-09-16 21:51 ` Junio C Hamano
2023-09-17 19:22 ` Mark Levedahl
2023-09-17 19:24 ` [PATCH] git-gui - use git-hook, honor core.hooksPath Mark Levedahl
2023-09-18 15:27 ` Johannes Schindelin
2023-09-18 15:58 ` Junio C Hamano
2023-09-18 16:25 ` Mark Levedahl
2023-09-18 17:53 ` Junio C Hamano [this message]
2023-09-20 13:05 ` Pratyush Yadav
2023-09-20 15:30 ` Mark Levedahl
2023-09-20 16:58 ` Junio C Hamano
2023-09-20 15:49 ` Junio C Hamano
2023-09-18 15:26 ` [PATCH v2] git-gui - re-enable use of hook scripts Johannes Schindelin
2023-09-18 16:04 ` Junio C Hamano
2023-09-20 13:27 ` Pratyush Yadav
2023-09-16 4:45 ` BUG: git-gui no longer executes " Junio C Hamano
2023-09-16 12:56 ` Mark Levedahl
2023-09-16 14:49 ` Mark Levedahl
2023-09-16 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5tjl65x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.