All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Mark Levedahl <mlevedahl@gmail.com>,
	me@yadavpratyush.com, git@vger.kernel.org
Subject: Re: [PATCH v2] git-gui - re-enable use of hook scripts
Date: Mon, 18 Sep 2023 09:04:51 -0700	[thread overview]
Message-ID: <xmqqjzsnmpr0.fsf@gitster.g> (raw)
In-Reply-To: <260b62dc-d45b-58fa-85c4-ffbd981a1c84@gmx.de> (Johannes Schindelin's message of "Mon, 18 Sep 2023 17:26:21 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Sounds good. FWIW I ran a couple experiments here, too:
>
> 	% file pathtype "C:/foo"
> 	absolute
> 	% file pathtype ".git/hooks"
> 	relative
> 	% file pathtype ".git\\hooks"
> 	relative
> 	% file pathtype "/foo"
> 	volumerelative
> 	% file pathtype "foo"
> 	relative
>
> The problem, therefore, is that `file pathtype` does not discern between a
> bare file name and a relative path. The proposed patch looks correct to
> me.
>
> Thank you,
> Johannes

Yup, the other "run hooks in a more modern way using 'git hook'"
patch is the right solution for the immediate breakage, but it still
cannot remove this sanitize_command_line proc as we have other users
and use cases where we want to use the sanitized $PATH search, so
this fix is still needed.

Thanks for a quick review on both patches.

  reply	other threads:[~2023-09-18 16:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 16:45 BUG: git-gui no longer executes hook scripts Mark Levedahl
2023-09-15 17:00 ` Junio C Hamano
2023-09-15 17:15   ` Junio C Hamano
2023-09-15 23:33     ` Mark Levedahl
2023-09-16  0:35       ` [PATCH] git-gui - re-enable use of " Mark Levedahl
2023-09-16 17:28         ` Junio C Hamano
2023-09-16 21:01           ` [PATCH v2] " Mark Levedahl
2023-09-16 21:51             ` Junio C Hamano
2023-09-17 19:22               ` Mark Levedahl
2023-09-17 19:24                 ` [PATCH] git-gui - use git-hook, honor core.hooksPath Mark Levedahl
2023-09-18 15:27                   ` Johannes Schindelin
2023-09-18 15:58                     ` Junio C Hamano
2023-09-18 16:25                       ` Mark Levedahl
2023-09-18 17:53                         ` Junio C Hamano
2023-09-20 13:05                   ` Pratyush Yadav
2023-09-20 15:30                     ` Mark Levedahl
2023-09-20 16:58                       ` Junio C Hamano
2023-09-20 15:49                     ` Junio C Hamano
2023-09-18 15:26             ` [PATCH v2] git-gui - re-enable use of hook scripts Johannes Schindelin
2023-09-18 16:04               ` Junio C Hamano [this message]
2023-09-20 13:27             ` Pratyush Yadav
2023-09-16  4:45       ` BUG: git-gui no longer executes " Junio C Hamano
2023-09-16 12:56         ` Mark Levedahl
2023-09-16 14:49           ` Mark Levedahl
2023-09-16 17:31             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjzsnmpr0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    --cc=mlevedahl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.