From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH] ci: run `make sparse` as a GitHub workflow
Date: Wed, 14 Jul 2021 13:56:09 -0700 [thread overview]
Message-ID: <xmqqa6movcly.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2107142252060.59@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 14 Jul 2021 22:54:07 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Junio,
>
> On Wed, 14 Jul 2021, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > Which means that the likelihood of a run to fail increases with the number
>> > of jobs in said run (even innocuous problems such as transient failures to
>> > download an Ubuntu package), and it also makes it much more painful to
>> > re-run the entire thing because you may well end up wasting a grand total
>> > of ~370 minutes even if only a 30-second-job would need to be re-run.
>> >
>> > Having said that, I think you're right and the upside of keeping things
>> > together may outweigh that downside.
>>
>> I wasn't make a request or a demand to change or not to change
>> anything, so in this particular exchange there was no point where I
>> was right (or wrong, for that matter ;-). I was asking if there was
>> a solid reasoning behind the split, and if there is, I am perfectly
>> happy to see it done as a separate workflow with the log message
>> that explains why it is separate. I am also perfectly fine with
>> this rolled into the primary one, with clear reasoning behind the
>> choice recorded in the log message.
>
> I do not think that it would be an improvement to defend the default
> choice (i.e. to add this new job to `.github/workflows/main.yml`) in the
> commit message. It is the default for new CI stuff to go, after all, and
> we do not need to clutter the message by stating the obvious.
It wasn't quite obvious why we justify spending 370 minutes one more
time only to rerun 30-second job, though.
next prev parent reply other threads:[~2021-07-14 20:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:51 [PATCH] ci: run `make sparse` as a GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-13 16:55 ` Đoàn Trần Công Danh
2021-07-14 9:12 ` Johannes Schindelin
2021-07-13 17:34 ` Philippe Blain
2021-07-14 9:09 ` Johannes Schindelin
2021-07-14 10:13 ` Johannes Schindelin
2021-07-16 1:37 ` Ramsay Jones
2021-07-13 22:41 ` Junio C Hamano
2021-07-14 10:09 ` Johannes Schindelin
2021-07-14 16:00 ` Junio C Hamano
2021-07-14 20:54 ` Johannes Schindelin
2021-07-14 20:56 ` Junio C Hamano [this message]
2021-07-14 22:03 ` Johannes Schindelin
2021-07-14 22:27 ` Junio C Hamano
2021-07-16 15:25 ` Johannes Schindelin
2021-07-16 16:42 ` Junio C Hamano
2021-07-14 11:50 ` [PATCH v2] ci: run `make sparse` as part of the " Johannes Schindelin via GitGitGadget
2021-07-26 17:53 ` [PATCH] ci: run "apt-get update" before "apt-get install" Jeff King
2021-07-26 18:22 ` Jeff King
2021-07-26 22:12 ` Junio C Hamano
2021-07-26 20:27 ` [PATCH v3] ci: run `make sparse` as part of the GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-26 22:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6movcly.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.