All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH] ci: run `make sparse` as a GitHub workflow
Date: Wed, 14 Jul 2021 15:27:34 -0700	[thread overview]
Message-ID: <xmqqsg0gttt5.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2107142350570.59@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Thu, 15 Jul 2021 00:03:52 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> It wasn't quite obvious why we justify spending 370 minutes one more
>> time only to rerun 30-second job, though.
>
> True.
>
> And this is not a new problem. Every time anything happens in those
> `osx-gcc` or `osx-clang` jobs (e.g. that transient problem with the broken
> pipes in t5516 [*1*], that's a fun one), a full re-run is necessary, or
> else the commit and/or PR will remain marked as broken.
>
> In other words, while it is totally appropriate for me to explain this to
> you in this here thread because it came up as a tangent, it would be
> inappropriate to stick that explanation into this patch's commit message.
> We do not make a habit of adding tangents that came up during patch
> reviews into commit messages, and I do not intend to start such a habit
> here, either.

I do not agree; a brief mention "even though piling more and more on
the primary workflow would make it even less convenient to re-run,
it is already so bad that another one would not hurt too much more"
would be a clue good enough to motivate others to do something about
it if they feel like it.


  reply	other threads:[~2021-07-14 22:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 11:51 [PATCH] ci: run `make sparse` as a GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-13 16:55 ` Đoàn Trần Công Danh
2021-07-14  9:12   ` Johannes Schindelin
2021-07-13 17:34 ` Philippe Blain
2021-07-14  9:09   ` Johannes Schindelin
2021-07-14 10:13     ` Johannes Schindelin
2021-07-16  1:37       ` Ramsay Jones
2021-07-13 22:41 ` Junio C Hamano
2021-07-14 10:09   ` Johannes Schindelin
2021-07-14 16:00     ` Junio C Hamano
2021-07-14 20:54       ` Johannes Schindelin
2021-07-14 20:56         ` Junio C Hamano
2021-07-14 22:03           ` Johannes Schindelin
2021-07-14 22:27             ` Junio C Hamano [this message]
2021-07-16 15:25               ` Johannes Schindelin
2021-07-16 16:42                 ` Junio C Hamano
2021-07-14 11:50 ` [PATCH v2] ci: run `make sparse` as part of the " Johannes Schindelin via GitGitGadget
2021-07-26 17:53   ` [PATCH] ci: run "apt-get update" before "apt-get install" Jeff King
2021-07-26 18:22     ` Jeff King
2021-07-26 22:12     ` Junio C Hamano
2021-07-26 20:27   ` [PATCH v3] ci: run `make sparse` as part of the GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-26 22:20     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsg0gttt5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.