All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ian Jackson <ijackson@chiark.greenend.org.uk>
Cc: Jeff King <peff@peff.net>, Jacob Keller <jacob.keller@gmail.com>,
	Git mailing list <git@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/6] config docs: Provide for config to specify tags not to abbreviate
Date: Tue, 08 Nov 2016 21:55:30 -0800	[thread overview]
Message-ID: <xmqqa8d9b3jh.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <22562.32428.287354.214659@chiark.greenend.org.uk> (Ian Jackson's message of "Wed, 9 Nov 2016 01:41:00 +0000")

Ian Jackson <ijackson@chiark.greenend.org.uk> writes:

>> I think the two things I found weird were:
>> 
>>   - it's in the "log" section, which makes me think it's an option for
>>     git-log. But it's not. I'm not sure what the _right_ section is, but
>>     hopefully it would make it clear that this is command-agnostic.
>> 
>>     Something like "gui.abbrevTags" might be OK (and as you note, has
>>     precedence). But of course it's possible that a command like "tig"
>>     could learn to support it.  I'm not sure if that counts as a GUI or
>>     not. :)
>
> I don't really have an opinion about the name.  gui.abbrevTags would
> be a possibility.  (It's a bit odd that implicitly, the default would
> be `*'.)

I have trouble with both "log" and "abbrev" in the name.  Perhaps I
am biased by our recent discussion on a feature in the core that we
use the word "abbrev" to describe, but I fear that most Git users,
when told the word, would imagine the act of shortening 40-hex full
object name down to shorter but still unique prefix, not the "this
refname is too long, so let's show only the first few letters in GUI
label".

And I do not think we would want "log" or any core side Porcelain
command to have too many "information losing" options like this
"truncate refnames down to a point where it is no longer unique and
meaningful".  GUI tools can get away with doing sos because they can
arrange these truncated labels to react to end-user input (e.g. the
truncated Tag in the history display of gitk could be made to react
to mouse-over and pop-up to show a full name, for example), but the
output from the core side is pretty much fixed once it is emitted.

So my first preference would be to teach gitk such a "please
clarify" UI-reaction, if it does not know how to do so yet.  There
is no need for a configuration variable anywhere with this approach.

If you do want to add a configuration to show fuller name in the
tag, which would make it unnecessary for the user to do "please
clarify, as I am hovering over what I want to get details of"
action, that may also be a good way to go.  But I think the right
place to do so would be Edit -> Preferences menu in Gitk, and the
settings will be stored in ~/.gitk or ~/.config/git/gitk or whatever
gitk-specific place.


  reply	other threads:[~2016-11-09  5:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  0:52 [PATCH 0/6] Provide for config to specify tags not to abbreviate Ian Jackson
2016-11-08  0:52 ` [PATCH GITK 1/6] gitk: Internal: drawtags: Abolish "singletag" variable Ian Jackson
2016-11-08  0:52 ` [PATCH GITK 2/6] gitk: Internal: drawtags: Idempotently reset "ntags" Ian Jackson
2016-11-08  0:52 ` [PATCH GITK 3/6] gitk: drawtags: Introduce concept of unabbreviated marks Ian Jackson
2016-11-08  0:52 ` [PATCH GITK 4/6] gitk: Provide for config to specify tags not to abbreviate Ian Jackson
2016-11-08  0:52 ` [PATCH 5/6] config docs: " Ian Jackson
2016-11-08  2:28   ` Jacob Keller
2016-11-08 10:51     ` Ian Jackson
2016-11-08 21:57       ` Jeff King
2016-11-09  1:41         ` Ian Jackson
2016-11-09  5:55           ` Junio C Hamano [this message]
2016-11-09 10:51             ` Ian Jackson
2016-11-09 23:13               ` Junio C Hamano
2016-11-09 23:31                 ` Ian Jackson
2016-11-10  0:36                   ` Markus Hitter
2016-11-08  0:54 ` [PATCH 0/6] " Ian Jackson
2016-11-08  9:19   ` Markus Hitter
2016-11-08 13:42     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa8d9b3jh.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ijackson@chiark.greenend.org.uk \
    --cc=jacob.keller@gmail.com \
    --cc=paulus@samba.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.