From: Junio C Hamano <gitster@pobox.com>
To: Ian Jackson <ijackson@chiark.greenend.org.uk>
Cc: Jeff King <peff@peff.net>, Jacob Keller <jacob.keller@gmail.com>,
Git mailing list <git@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/6] config docs: Provide for config to specify tags not to abbreviate
Date: Wed, 09 Nov 2016 15:13:32 -0800 [thread overview]
Message-ID: <xmqqeg2k8cwz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <22562.65461.845411.29907@chiark.greenend.org.uk> (Ian Jackson's message of "Wed, 9 Nov 2016 10:51:33 +0000")
Ian Jackson <ijackson@chiark.greenend.org.uk> writes:
>> But I think the right
>> place to do so would be Edit -> Preferences menu in Gitk, and the
>> settings will be stored in ~/.gitk or ~/.config/git/gitk or whatever
>> gitk-specific place.
>
> This is not correct, because as I have explained, this should be a
> per-tree configuration:
I do not have fundamental opposition to make it part of .git/config,
but the name "gitk.something" or if you are enhancing git-gui at the
time perhaps "gui.something" would be appropriate.
But it is still silly to have this kind of information that is very
specific to Gitk in two places, one that is pretty Gitk specific
that core-git does not know anything about, the other that are part
of the configuration storage of the core-git. In the longer term,
it is necessary for them to be accessible from gitk's "Edit ->
Preferences" mechanism somehow, I would think, rather than forcing
users to sometimes go to GUI to tweak and sometimes run "git config".
next prev parent reply other threads:[~2016-11-09 23:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 0:52 [PATCH 0/6] Provide for config to specify tags not to abbreviate Ian Jackson
2016-11-08 0:52 ` [PATCH GITK 1/6] gitk: Internal: drawtags: Abolish "singletag" variable Ian Jackson
2016-11-08 0:52 ` [PATCH GITK 2/6] gitk: Internal: drawtags: Idempotently reset "ntags" Ian Jackson
2016-11-08 0:52 ` [PATCH GITK 3/6] gitk: drawtags: Introduce concept of unabbreviated marks Ian Jackson
2016-11-08 0:52 ` [PATCH GITK 4/6] gitk: Provide for config to specify tags not to abbreviate Ian Jackson
2016-11-08 0:52 ` [PATCH 5/6] config docs: " Ian Jackson
2016-11-08 2:28 ` Jacob Keller
2016-11-08 10:51 ` Ian Jackson
2016-11-08 21:57 ` Jeff King
2016-11-09 1:41 ` Ian Jackson
2016-11-09 5:55 ` Junio C Hamano
2016-11-09 10:51 ` Ian Jackson
2016-11-09 23:13 ` Junio C Hamano [this message]
2016-11-09 23:31 ` Ian Jackson
2016-11-10 0:36 ` Markus Hitter
2016-11-08 0:54 ` [PATCH 0/6] " Ian Jackson
2016-11-08 9:19 ` Markus Hitter
2016-11-08 13:42 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeg2k8cwz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ijackson@chiark.greenend.org.uk \
--cc=jacob.keller@gmail.com \
--cc=paulus@samba.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.