From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jan 2016, #02; Mon, 11)
Date: Mon, 25 Jan 2016 14:03:45 -0800 [thread overview]
Message-ID: <xmqqa8ntfha6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACsJy8D2x1DtzNGB+zjoLxNwZoG2cVkkU9=ziHtRiV6rfBVc7Q@mail.gmail.com> (Duy Nguyen's message of "Mon, 25 Jan 2016 16:56:20 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> On Tue, Jan 12, 2016 at 6:45 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> * jk/graph-format-padding (2015-09-14) 1 commit
>> - pretty: pass graph width to pretty formatting for use in '%>|(N)'
>>
>> Redefine the way '%>|(N)' padding and the "--graph" option
>> interacts. It has been that the available columns to display the
>> log message was measured from the edge of the area the graph ended,
>> but with this it becomes the beginning of the entire output.
>>
>> I have a suspicion that 50% of the users would appreciate this
>> change, and the remainder see this break their expectation. If
>> that is the case, we might need to introduce a similar but
>> different alignment operator so that this new behaviour is
>> available to those who want to use it, without negatively affecting
>> existing uses.
>>
>> No comments after waiting for a long time.
>> Will discard.
>> ($gmane/278326)
>
> I carried this in my tree and didn't realize it's dropped from 'pu'.
> There's actually a comment last month [1]. By your last comment, does
> it mean I should check if "it" breaks anything to resurrect this one?
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/277710/focus=282886
Ahh, yes, I remember that your response was that the patch is good
and we do not need a new separate way (as there already is one)
to specify the other behaviour. So if that is truly the case (I
didn't check it), we would certainly want to resurrect it, as there
wouldn't be any downside to it.
Thanks.
prev parent reply other threads:[~2016-01-25 22:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 23:45 What's cooking in git.git (Jan 2016, #02; Mon, 11) Junio C Hamano
2016-01-12 0:06 ` Mike Hommey
2016-01-12 3:04 ` Junio C Hamano
2016-01-12 4:34 ` Edmundo Carmona Antoranz
2016-01-12 8:39 ` Johannes Schindelin
2016-01-12 18:47 ` Junio C Hamano
2016-01-12 21:49 ` Jeff King
2016-01-13 23:07 ` Junio C Hamano
2016-01-13 23:22 ` Jeff King
2016-01-13 23:44 ` Junio C Hamano
2016-01-13 23:54 ` Junio C Hamano
2016-01-14 10:21 ` Jeff King
2016-01-13 2:56 ` David A. Greene
2016-01-18 13:35 ` Michael J Gruber
2016-01-18 17:06 ` Jeff King
2016-01-18 21:39 ` Eric Wong
2016-01-19 7:07 ` Michael J Gruber
2016-01-25 9:56 ` Duy Nguyen
2016-01-25 22:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8ntfha6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.