From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2016, #02; Mon, 11)
Date: Tue, 12 Jan 2016 10:47:25 -0800 [thread overview]
Message-ID: <xmqqtwmitz2a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1601120939270.2964@virtualbox> (Johannes Schindelin's message of "Tue, 12 Jan 2016 09:39:53 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> Rerolled.
>> Needs review.
>
> Actually, it waits for a re-roll ;-)
True.
I think strbuf_getline() that handles the payload as "text" without
having _crlf() suffix is an ideal endgame in the longer term, but I
do not think it is a good idea to do that as a flag-day change. So
I am inclined not to change the function names around that feature
in this series. Others can do the wholesale rename as a separate
follow-up topic when the tree is quiescent.
The other point "We prepared to be able to use line termination
other than LF and NUL, but in practice nobody uses other values, so
tighten the interface to clarify that we allow only these two
values" you raised is something I think should be done as a
preparatory step for this series, as the correctness of the series
depends heavily on that assumption that nobody ever uses any other
value than LF or NUL. I am looking at it but haven't published any
progress yet.
Thanks.
next prev parent reply other threads:[~2016-01-12 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 23:45 What's cooking in git.git (Jan 2016, #02; Mon, 11) Junio C Hamano
2016-01-12 0:06 ` Mike Hommey
2016-01-12 3:04 ` Junio C Hamano
2016-01-12 4:34 ` Edmundo Carmona Antoranz
2016-01-12 8:39 ` Johannes Schindelin
2016-01-12 18:47 ` Junio C Hamano [this message]
2016-01-12 21:49 ` Jeff King
2016-01-13 23:07 ` Junio C Hamano
2016-01-13 23:22 ` Jeff King
2016-01-13 23:44 ` Junio C Hamano
2016-01-13 23:54 ` Junio C Hamano
2016-01-14 10:21 ` Jeff King
2016-01-13 2:56 ` David A. Greene
2016-01-18 13:35 ` Michael J Gruber
2016-01-18 17:06 ` Jeff King
2016-01-18 21:39 ` Eric Wong
2016-01-19 7:07 ` Michael J Gruber
2016-01-25 9:56 ` Duy Nguyen
2016-01-25 22:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwmitz2a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.