From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, git@jowil.de
Subject: Re: [PATCH 1/4] refs: move ref name helpers around
Date: Tue, 03 Dec 2024 10:23:25 +0900 [thread overview]
Message-ID: <xmqqbjxth84y.fsf@gitster.g> (raw)
In-Reply-To: <20241202203743.GB776185@coredump.intra.peff.net> (Jeff King's message of "Mon, 2 Dec 2024 15:37:43 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Dec 02, 2024 at 04:07:11PM +0900, Junio C Hamano wrote:
>
>> strbuf_branchname(), strbuf_check_{branch,tag}_ref() are helper
>> functions to deal with branch and tag names, and the fact that they
>> happen to use strbuf to hold the name of a branch or a tag is not
>> essential. These functions fit better in the refs API than strbuf
>> API, the latter of which is about string manipulations.
>
> Wow, they are declared in strbuf.h but not even implemented there. So it
> was doubly confusing. This looks like a nice cleanup.
Yup. Another home that may want to adopt them is the object-name
API, but I think refs API is good enough, and certainly better than
strbuf.
next prev parent reply other threads:[~2024-12-03 1:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 7:07 [PATCH 0/4] forbid HEAD as a tagname Junio C Hamano
2024-12-02 7:07 ` [PATCH 1/4] refs: move ref name helpers around Junio C Hamano
2024-12-02 20:37 ` Jeff King
2024-12-03 1:23 ` Junio C Hamano [this message]
2024-12-02 7:07 ` [PATCH 2/4] refs: drop strbuf_ prefix from helpers Junio C Hamano
2024-12-02 20:51 ` Jeff King
2024-12-02 7:07 ` [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname Junio C Hamano
2024-12-02 12:19 ` Kristoffer Haugsbakk
2024-12-02 21:00 ` Jeff King
2024-12-02 21:09 ` Kristoffer Haugsbakk
2024-12-03 1:29 ` Junio C Hamano
2024-12-05 20:25 ` Jeff King
2024-12-02 20:52 ` Jeff King
2024-12-02 7:07 ` [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname Junio C Hamano
2024-12-02 10:54 ` Patrick Steinhardt
2024-12-02 13:01 ` shejialuo
2024-12-03 1:30 ` Junio C Hamano
2024-12-05 20:26 ` Jeff King
2024-12-05 20:27 ` Jeff King
2024-12-02 20:42 ` Rubén Justo
2024-12-03 1:35 ` Junio C Hamano
2024-12-02 21:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjxth84y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@jowil.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.