All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: shejialuo <shejialuo@gmail.com>
Cc: git@vger.kernel.org,  git@jowil.de,  Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname
Date: Tue, 03 Dec 2024 10:30:15 +0900	[thread overview]
Message-ID: <xmqqy10xft94.fsf@gitster.g> (raw)
In-Reply-To: <Z02voaSNYRciv38z@ArchLinux> (shejialuo@gmail.com's message of "Mon, 2 Dec 2024 21:01:21 +0800")

shejialuo <shejialuo@gmail.com> writes:

>>  int check_tag_ref(struct strbuf *sb, const char *name)
>>  {
>> -	if (name[0] == '-')
>> +	if (name[0] == '-' || !strcmp(name, "HEAD"))
>
> I am wondering whether we should also update "check_refname_format"
> function to report "refs/heads/HEAD" and "refs/tags/HEAD" is bad ref
> name.

Check the list archive for the past few days; it was considered and
rejected.

Thanks.

  reply	other threads:[~2024-12-03  1:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  7:07 [PATCH 0/4] forbid HEAD as a tagname Junio C Hamano
2024-12-02  7:07 ` [PATCH 1/4] refs: move ref name helpers around Junio C Hamano
2024-12-02 20:37   ` Jeff King
2024-12-03  1:23     ` Junio C Hamano
2024-12-02  7:07 ` [PATCH 2/4] refs: drop strbuf_ prefix from helpers Junio C Hamano
2024-12-02 20:51   ` Jeff King
2024-12-02  7:07 ` [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname Junio C Hamano
2024-12-02 12:19   ` Kristoffer Haugsbakk
2024-12-02 21:00     ` Jeff King
2024-12-02 21:09       ` Kristoffer Haugsbakk
2024-12-03  1:29       ` Junio C Hamano
2024-12-05 20:25         ` Jeff King
2024-12-02 20:52   ` Jeff King
2024-12-02  7:07 ` [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname Junio C Hamano
2024-12-02 10:54   ` Patrick Steinhardt
2024-12-02 13:01   ` shejialuo
2024-12-03  1:30     ` Junio C Hamano [this message]
2024-12-05 20:26       ` Jeff King
2024-12-05 20:27         ` Jeff King
2024-12-02 20:42   ` Rubén Justo
2024-12-03  1:35     ` Junio C Hamano
2024-12-02 21:03   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy10xft94.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@jowil.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=shejialuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.