All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Aditya Neelamraju via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Aditya Neelamraju <adityanv97@gmail.com>
Subject: Re: [PATCH] chore: fix typo in .clang-format comment
Date: Wed, 01 Nov 2023 08:40:36 +0900	[thread overview]
Message-ID: <xmqqbkce1hu3.fsf@gitster.g> (raw)
In-Reply-To: <ZUFQzFcgGdJsPJ8G@nand.local> (Taylor Blau's message of "Tue, 31 Oct 2023 15:09:00 -0400")

Taylor Blau <me@ttaylorr.com> writes:

>> As a comment for a new contributor, it is a bit unhelpful not to
>> suggest what the "subject area" string we would use if we were
>> working on this patch, I think.
>
> Good suggestion. I would have suggested "clang-format", which is
> exactly Aditya ended up choosing, anyway. Thanks, Aditya!

Thanks.  I was being lazy when I said the above ;-)

Teaching how to fish instead of giving fish, the way I would have
done is

   $ git log --no-merges --stat --full-diff .clang-format

and inspect what they use.  The ones that used "clang-format:" are
indeed very similar in spirit to what this one does, I would say.

Thanks.


  reply	other threads:[~2023-10-31 23:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 20:23 [PATCH] chore: fix typo in .clang-format comment Aditya Neelamraju via GitGitGadget
2023-10-30 16:56 ` Taylor Blau
2023-10-31  3:12   ` Junio C Hamano
2023-10-31 19:09     ` Taylor Blau
2023-10-31 23:40       ` Junio C Hamano [this message]
2023-10-31 13:40 ` [PATCH v2] clang-format: fix typo in comment Aditya Neelamraju via GitGitGadget
2023-10-31 19:09   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbkce1hu3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adityanv97@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.