From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Aditya Neelamraju via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Aditya Neelamraju <adityanv97@gmail.com>
Subject: Re: [PATCH] chore: fix typo in .clang-format comment
Date: Tue, 31 Oct 2023 12:12:43 +0900 [thread overview]
Message-ID: <xmqqpm0v5vtg.fsf@gitster.g> (raw)
In-Reply-To: <ZT/gQZlVKfgn/+BZ@nand.local> (Taylor Blau's message of "Mon, 30 Oct 2023 12:56:33 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:
>> From: Aditya Neelamraju <adityanv97@gmail.com>
>
> We typically prefix commit messages with the subject area they're
> working in, not with "chore", or "feat" like some Git workflows
> recommend.
> ...
> That said, the contents of this patch look obviously correct to me.
> Thanks for noticing and fixing!
As a comment for a new contributor, it is a bit unhelpful not to
suggest what the "subject area" string we would use if we were
working on this patch, I think.
I also suspected that valuve may be a valid word in some language,
as the indentation in the example looked as if the six-letter word
was meant, not typoed. https://www.gasolineravaluve.com/ was one
of the first hits I saw in my search ;-)
next prev parent reply other threads:[~2023-10-31 3:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 20:23 [PATCH] chore: fix typo in .clang-format comment Aditya Neelamraju via GitGitGadget
2023-10-30 16:56 ` Taylor Blau
2023-10-31 3:12 ` Junio C Hamano [this message]
2023-10-31 19:09 ` Taylor Blau
2023-10-31 23:40 ` Junio C Hamano
2023-10-31 13:40 ` [PATCH v2] clang-format: fix typo in comment Aditya Neelamraju via GitGitGadget
2023-10-31 19:09 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpm0v5vtg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adityanv97@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.