All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Steven Penny <svnpenn@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send
Date: Mon, 09 Jan 2017 06:23:57 -0800	[thread overview]
Message-ID: <xmqqbmvgwbuq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701091127570.3469@virtualbox> (Johannes Schindelin's message of "Mon, 9 Jan 2017 11:49:37 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> ...
> It is a bit curious that -lws2_32 *does* only show up in $(LIBS), but I
> guess it is simply the fact that we use a newer GCC (gcc.exe (Rev2, Built
> by MSYS2 project) 6.2.0) that allows Git for Windows to be built even
> without this patch.
>
> In any case, it does not break things, and it helps Cygwin, so: ACK

Thanks, will queue on my side, too.

  reply	other threads:[~2017-01-09 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08  6:12 [PATCH] Makefile: put LIBS after LDFLAGS for imap-send Steven Penny
2017-01-08 11:54 ` Johannes Schindelin
2017-01-08 15:12   ` Steven Penny
2017-01-08 18:54     ` Johannes Schindelin
2017-01-09  3:07       ` Junio C Hamano
2017-01-09 10:49         ` Johannes Schindelin
2017-01-09 14:23           ` Junio C Hamano [this message]
2017-01-09 14:27           ` Junio C Hamano
2017-01-09 14:31             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbmvgwbuq.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=svnpenn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.