From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Steven Penny <svnpenn@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send
Date: Sun, 08 Jan 2017 19:07:55 -0800 [thread overview]
Message-ID: <xmqqy3ylx75g.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701081953330.3469@virtualbox> (Johannes Schindelin's message of "Sun, 8 Jan 2017 19:54:23 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Steven,
>
> On Sun, 8 Jan 2017, Steven Penny wrote:
>
>> On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote:
>> > I am curious: how do you build Git? I ask because I build Git on Windows
>> > many times a day, and I did not encounter any link problems.
>>
>> My end goal is to build static native Windows Git via Cygwin and the
>> mingw64-x86_64-gcc-core package.
>
> That is certainly a worthy goal, and I would highly recommend to mention
> that particular cross-compiling setup in the commit message. It's not like
> this is the easiest way to build native Git on Windows...
In addition to the patch being explained well, I also care that it
does not break existing builds. I do not think it is the case for
you, and I do think the patch does the right thing, but just double
checking to see if you have objections to the change itself.
Thanks.
next prev parent reply other threads:[~2017-01-09 3:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 6:12 [PATCH] Makefile: put LIBS after LDFLAGS for imap-send Steven Penny
2017-01-08 11:54 ` Johannes Schindelin
2017-01-08 15:12 ` Steven Penny
2017-01-08 18:54 ` Johannes Schindelin
2017-01-09 3:07 ` Junio C Hamano [this message]
2017-01-09 10:49 ` Johannes Schindelin
2017-01-09 14:23 ` Junio C Hamano
2017-01-09 14:27 ` Junio C Hamano
2017-01-09 14:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3ylx75g.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=svnpenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.