From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] New config option for git-grep to include untracked files
Date: Tue, 19 Mar 2024 10:43:00 -0700 [thread overview]
Message-ID: <xmqqcyrqqfrv.fsf@gitster.g> (raw)
In-Reply-To: <c68a6d94bb02e5d9aa2f81bee022baa8@manjaro.org> (Dragan Simic's message of "Tue, 19 Mar 2024 06:09:34 +0100")
Dragan Simic <dsimic@manjaro.org> writes:
> However, I think that the usability of this new configuration option
> outweighs the possible issues it could cause to some users.
"Screw others who share my preference and want to set this variable,
but use third-party tools and scripts that will get broken with this
change, because I do not use them" is what we try not to say around
here.
> For example, I quite often find myself in need to specify
> --untracked while running git-grep(1), to see what's found in the
> code changes I haven't staged yet, so I find this new
> configuration very useful.
The feature (not the command line option, but the behaviour that is
triggered by it) surely may be useful. Otherwise we wouldn't have
added it. As I already said, I often find myself doing "--cached".
But that does not make it a good idea to invent a new configuration
variable and set "grep.source=cached".
next prev parent reply other threads:[~2024-03-19 17:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 17:03 [PATCH 0/5] New config option for git-grep to include untracked files Dragan Simic
2024-03-18 17:03 ` [PATCH 1/5] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-18 19:59 ` Eric Sunshine
2024-03-18 22:03 ` Dragan Simic
2024-03-19 0:32 ` Junio C Hamano
2024-03-19 5:33 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 2/5] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-18 20:02 ` Eric Sunshine
2024-03-18 22:14 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 3/5] grep docs: describe --no-index further Dragan Simic
2024-03-19 0:55 ` Junio C Hamano
2024-03-19 5:37 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 4/5] grep: introduce new config option to include untracked files Dragan Simic
2024-03-19 0:58 ` Junio C Hamano
2024-03-19 5:47 ` Dragan Simic
2024-03-19 14:32 ` Junio C Hamano
2024-03-19 14:52 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 5/5] grep docs: describe " Dragan Simic
2024-03-19 0:21 ` [PATCH 0/5] New config option for git-grep " Junio C Hamano
2024-03-19 5:09 ` Dragan Simic
2024-03-19 17:43 ` Junio C Hamano [this message]
2024-03-19 17:48 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyrqqfrv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.