All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Jake Goulding <goulding@vivisimo.com>, Jeff King <peff@peff.net>,
	Tom Grennan <tmgrennan@gmail.com>,
	Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH] tag: Implicitly supply --list given another list-like option
Date: Sat, 11 Mar 2017 18:51:59 -0800	[thread overview]
Message-ID: <xmqqefy3w6k0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX4AJqvtZQdZZFU8+1So5G9F11_SN4=za+8p=KYim9SFSQ@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 11 Mar 2017 13:14:48 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> Junio: This will merge conflict with my in-flight --no-contains
>> patch. I can re-send either one depending on which you want to accept
>> first, this patch will need an additional test for --no-contains. I
>> just wanted to get this on the ML for review before the --no-contains
>> patch hit "master".

I haven't looked at the patch text of this one closely yet, but I
think the goals of both make sense, so we would eventually want to
have them both.

I also think that "if you said --contains, --merged, etc. you are
already asking to give you a list and cannot be creating a new one",
which is the topic of this patch, makes sense even if nobody were
interested in asking "--no-contains".

So perhaps you would want this applied first, so that existing three
can already benefit from "implicit --list" before waiting for the
other one?


  reply	other threads:[~2017-03-12  2:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 10:43 BUG: "git branch --contains <commit> <name>" does nothing, silently fails Ævar Arnfjörð Bjarmason
2017-03-10 12:42 ` Jeff King
2017-03-10 13:23   ` Ævar Arnfjörð Bjarmason
2017-03-11 12:08   ` [PATCH] tag: Implicitly supply --list given another list-like option Ævar Arnfjörð Bjarmason
2017-03-11 12:14     ` Ævar Arnfjörð Bjarmason
2017-03-12  2:51       ` Junio C Hamano [this message]
2017-03-12  3:00         ` Junio C Hamano
2017-03-12  9:15         ` Ævar Arnfjörð Bjarmason
2017-03-12  3:19     ` Junio C Hamano
2017-03-12  9:15       ` Ævar Arnfjörð Bjarmason
2017-03-12 11:19     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqefy3w6k0.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=goulding@vivisimo.com \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=tmgrennan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.