* [PATCH] t1410: check files and missing paths after reflog rewind
@ 2026-01-11 14:03 Pushkar Singh
2026-01-11 18:41 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Pushkar Singh @ 2026-01-11 14:03 UTC (permalink / raw)
To: git
Replace raw `test -f` and `! test -f` checks in the rewind test with
`test_path_is_file` and `test_path_is_missing`. This provides clearer
failure diagnostics and keeps the test consistent with the rest of
the test suite.
Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
t/t1410-reflog.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
index e30f87a358..ce71f9a30a 100755
--- a/t/t1410-reflog.sh
+++ b/t/t1410-reflog.sh
@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '
test_expect_success rewind '
test_tick && git reset --hard HEAD~2 &&
- test -f C &&
- test -f A/B/E &&
- ! test -f F &&
- ! test -f A/G &&
+ test_path_is_file C &&
+ test_path_is_file A/B/E &&
+ test_path_is_missing F &&
+ test_path_is_missing A/G &&
check_have A B C D E F G H I J K L &&
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t1410: check files and missing paths after reflog rewind
2026-01-11 14:03 [PATCH] t1410: check files and missing paths after reflog rewind Pushkar Singh
@ 2026-01-11 18:41 ` Junio C Hamano
2026-01-11 19:07 ` [PATCH v2] t1410: use test helpers in reflog rewind test Pushkar Singh
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2026-01-11 18:41 UTC (permalink / raw)
To: Pushkar Singh; +Cc: git
Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
> Subject: [PATCH] t1410: check files and missing paths after reflog rewind
That sounds as if the original did not check these things after
"reflog rewind" and this patch is about correcting it, doesn't it?
That is a bit different from what is really happening in this patch.
> Replace raw `test -f` and `! test -f` checks in the rewind test with
> `test_path_is_file` and `test_path_is_missing`. This provides clearer
> failure diagnostics and keeps the test consistent with the rest of
> the test suite.
On the other hand, this describes what the patch does nicely.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] t1410: use test helpers in reflog rewind test
2026-01-11 18:41 ` Junio C Hamano
@ 2026-01-11 19:07 ` Pushkar Singh
0 siblings, 0 replies; 3+ messages in thread
From: Pushkar Singh @ 2026-01-11 19:07 UTC (permalink / raw)
To: git; +Cc: gitster
Replace raw `test -f` and `! test -f` checks in the rewind test with
`test_path_is_file` and `test_path_is_missing`. This provides clearer
failure diagnostics and keeps the test consistent with the rest of
the test suite.
Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
t/t1410-reflog.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
index e30f87a358..ce71f9a30a 100755
--- a/t/t1410-reflog.sh
+++ b/t/t1410-reflog.sh
@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '
test_expect_success rewind '
test_tick && git reset --hard HEAD~2 &&
- test -f C &&
- test -f A/B/E &&
- ! test -f F &&
- ! test -f A/G &&
+ test_path_is_file C &&
+ test_path_is_file A/B/E &&
+ test_path_is_missing F &&
+ test_path_is_missing A/G &&
check_have A B C D E F G H I J K L &&
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-11 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-11 14:03 [PATCH] t1410: check files and missing paths after reflog rewind Pushkar Singh
2026-01-11 18:41 ` Junio C Hamano
2026-01-11 19:07 ` [PATCH v2] t1410: use test helpers in reflog rewind test Pushkar Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.