From: Junio C Hamano <gitster@pobox.com>
To: Paul Smith <psmith@gnu.org>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org,
Dario Gjorgjevski <dario.gjorgjevski@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] Makefile(s): avoid recipe prefix in conditional statements
Date: Mon, 08 Apr 2024 16:34:21 -0700 [thread overview]
Message-ID: <xmqqh6gb5szm.fsf@gitster.g> (raw)
In-Reply-To: <606990048585347654f3b4b187ec27f4dc1b85e3.camel@gnu.org> (Paul Smith's message of "Mon, 08 Apr 2024 19:24:16 -0400")
Paul Smith <psmith@gnu.org> writes:
> Just to note that this usage clearly contravenes the documentation,
> which states that preprocessor statement lines cannot begin with a TAB.
> It was a bug that this was allowed by the GNU Make parser.
>
> I understand that in many projects (Linux, probably Git :)) if the
> documentation and behavior disagreed then the documentation would be
> changed, not the behavior.
If a bug is left in a released version long enough, it becomes a
feature your users depend upon. We saw that happen to us, I am sure
the mantra "don't break userspace" the kernel project had comes from
the same place.
I am not sure what benefits are gained by the existing users with
this change to ease fixing some parser bug (I didn't bother to see
your bug tracker) so I cannot judge if the benefit outweighs the
cost of them all having to scramble and adjust to the new world
order.
next prev parent reply other threads:[~2024-04-08 23:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 10:44 Makefiles are broken as of GNU Make commit 07fcee35f058a876447c8a021f9eb1943f902534 Dario Gjorgjevski
2024-04-08 15:51 ` [PATCH] Makefile(s): avoid recipe prefix in conditional statements Taylor Blau
2024-04-08 21:41 ` Junio C Hamano
2024-04-08 23:24 ` Paul Smith
2024-04-08 23:34 ` Junio C Hamano [this message]
2024-04-09 20:41 ` Paul Smith
2024-04-08 23:44 ` Junio C Hamano
2024-04-09 20:42 ` Paul Smith
2024-04-09 21:23 ` Junio C Hamano
2024-04-09 0:04 ` Jeff King
2024-04-09 0:17 ` Jeff King
2024-04-09 20:44 ` Paul Smith
2024-04-08 23:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6gb5szm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dario.gjorgjevski@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=psmith@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.