All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org,
	 Dario Gjorgjevski <dario.gjorgjevski@gmail.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH] Makefile(s): avoid recipe prefix in conditional statements
Date: Mon, 08 Apr 2024 14:41:24 -0700	[thread overview]
Message-ID: <xmqqle5n8rcr.fsf@gitster.g> (raw)
In-Reply-To: <9d14c08ca6cc06cdf8fb4ba33d2470053dca3966.1712591504.git.me@ttaylorr.com> (Taylor Blau's message of "Mon, 8 Apr 2024 11:51:44 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> When a conditional word (ifeq, ifneq, ifdef, etc.) is preceded by one or
> more tab characters, replace each tab character with 8 space characters
> with the following:
>
>     find . -type f -not -path './.git/*' -name Makefile -or -name '*.mak' |
>       xargs perl -i -pe '
>         s/(\t+)(ifn?eq|ifn?def|else|endif)/" " x (length($1) * 8) . $2/ge unless /\\$/
>       '

Yuck, it means auto indenting Makefile and its pieces almost
impossible X-<.  I'll take the patch as there is no way to revert
the change to GNU make, though.

Thanks.

  reply	other threads:[~2024-04-08 21:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 10:44 Makefiles are broken as of GNU Make commit 07fcee35f058a876447c8a021f9eb1943f902534 Dario Gjorgjevski
2024-04-08 15:51 ` [PATCH] Makefile(s): avoid recipe prefix in conditional statements Taylor Blau
2024-04-08 21:41   ` Junio C Hamano [this message]
2024-04-08 23:24     ` Paul Smith
2024-04-08 23:34       ` Junio C Hamano
2024-04-09 20:41         ` Paul Smith
2024-04-08 23:44       ` Junio C Hamano
2024-04-09 20:42         ` Paul Smith
2024-04-09 21:23           ` Junio C Hamano
2024-04-09  0:04       ` Jeff King
2024-04-09  0:17         ` Jeff King
2024-04-09 20:44         ` Paul Smith
2024-04-08 23:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqle5n8rcr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dario.gjorgjevski@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.