From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] pack-redundant: escalate deprecation warning to an error
Date: Thu, 23 Mar 2023 14:23:46 -0700 [thread overview]
Message-ID: <xmqqh6ub6u1p.fsf@gitster.g> (raw)
In-Reply-To: <ZBzBr1EAXoqBwmVo@nand.local> (Taylor Blau's message of "Thu, 23 Mar 2023 17:16:31 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Thu, Mar 23, 2023 at 01:56:26PM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>>
>> > I was looking in this file recently, and was reminded of the deprecation
>> > plan. The two data points above do give me a little bit of pause, but it
>> > seems like the current state is the worst of both worlds: we do not have
>> > the benefit of dropping the code, and people who try to use the command
>> > have a bad experience. So we should probably either proceed (as with
>> > this patch), or decide we need to keep pack-redundant.
>>
>> Sounds like a good thing to do. Will queue. Thanks.
>
> Yeah, I agree with and am persuaded by the "worst of both worlds"
> argument. I think that changing this to a die() is sensible for now.
>
> At what point would it be fair to drop this builtin entirely from the
> tree?
I notice that "git pack-redundant --help" does not say anything
about its deprecation. We probably should add one together with
the patch in question, and then consider that the count-down timer
has finally started.
The timer should last probably for at least a few cycles.
next prev parent reply other threads:[~2023-03-23 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:40 [RFC/PATCH] pack-redundant: escalate deprecation warning to an error Jeff King
2023-03-23 20:56 ` Junio C Hamano
2023-03-23 21:16 ` Taylor Blau
2023-03-23 21:23 ` Junio C Hamano [this message]
2023-03-28 19:06 ` [PATCH] pack-redundant: document deprecation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6ub6u1p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.