Re: [RFC/PATCH] pack-redundant: escalate deprecation warning to an error

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> I was looking in this file recently, and was reminded of the deprecation
> plan. The two data points above do give me a little bit of pause, but it
> seems like the current state is the worst of both worlds: we do not have
> the benefit of dropping the code, and people who try to use the command
> have a bad experience. So we should probably either proceed (as with
> this patch), or decide we need to keep pack-redundant.

Sounds like a good thing to do.  Will queue.  Thanks.

>
>  builtin/pack-redundant.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c
> index 82115c5808c..5e93d873208 100644
> --- a/builtin/pack-redundant.c
> +++ b/builtin/pack-redundant.c
> @@ -604,6 +604,7 @@ int cmd_pack_redundant(int argc, const char **argv, const char *prefix)
>  			"option, '--i-still-use-this', on the command line\n"
>  			"and let us know you still use it by sending an e-mail\n"
>  			"to <git@vger.kernel.org>.  Thanks.\n"), stderr);
> +		die(_("refusing to run without --i-still-use-this"));
>  	}
>  
>  	if (load_all_packs)