From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, vagabon.xyz@gmail.com,
"Jeff King" <peff@peff.net>, "René Scharfe" <l.s.r@web.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH RESEND] archive: rewrite description for compression level option
Date: Thu, 14 Oct 2021 09:51:28 -0700 [thread overview]
Message-ID: <xmqqh7djczxr.fsf@gitster.g> (raw)
In-Reply-To: <20211014120233.7834-1-bagasdotme@gmail.com> (Bagas Sanjaya's message of "Thu, 14 Oct 2021 19:02:34 +0700")
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> Currently, the description of compression level option (`-<number>` or
> `-#`) only specifies two level (`-0` and `-9`), giving the impression
> that only both levels are accepted, although other level number can be
> specified. Rewrite the description.
While I find that the updated description is more detailed [*], I am
not sure if the change to the heading is an improvement for readers,
as I do not think of a case where users would choose to use anything
other than to use (1) no compression level option, (2) '-0' for
speed, or (3) '-9' for size, and explicitly singling out `-0` and
`-9` like the current text does would help those who wonder what the
option, used in a script written by somebody else that they are
given to maintain, mean, better than the updated text that does not
even allow /-9 in their pager to look for the description, if you
only had `-<number>` or `-#`.
Also, unless we take `-47`, I do not think it is a good idea to
spell it as `-<number>`. Perhaps `-<digit>` is OK, but it shares
exactly the same issue as `-<number>` I mentioned above.
Thanks.
[Footnote]
* Not that the original does not carry the same information; when
"-9" is described as "highest and slowest", accompanied by "any
number from 1 to 9 to adjust", the readers can easily read that
"Higher number indicates ..." tradeoff without getting told.
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> Documentation/git-archive.txt | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt
> index 9f8172828d..097b999bbd 100644
> --- a/Documentation/git-archive.txt
> +++ b/Documentation/git-archive.txt
> @@ -93,12 +93,11 @@ BACKEND EXTRA OPTIONS
>
> zip
> ~~~
> --0::
> - Store the files instead of deflating them.
> --9::
> - Highest and slowest compression level. You can specify any
> - number from 1 to 9 to adjust compression speed and ratio.
> -
> +-<number>::
> + Select the compression level. Higher number indicates better
> + compression at the expense of longer time to compress. Valid
> + values are from 0 to 9. If 0 is selected, the files will be
> + stored without compressing.
>
> CONFIGURATION
> -------------
>
> base-commit: 2bd2f258f4195ac54293a3f45b86457c0bd5fc11
next prev parent reply other threads:[~2021-10-14 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 12:02 [PATCH RESEND] archive: rewrite description for compression level option Bagas Sanjaya
2021-10-14 16:51 ` Junio C Hamano [this message]
2021-10-15 3:22 ` Bagas Sanjaya
2021-10-15 4:11 ` Ævar Arnfjörð Bjarmason
2021-10-15 6:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7djczxr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.