All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: git@vger.kernel.org, Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH 3/7] l10n: git-parse-remote.sh: mark strings for translation
Date: Fri, 08 Apr 2016 13:30:18 -0700	[thread overview]
Message-ID: <xmqqh9fbvo6d.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1460145765-7454-3-git-send-email-vascomalmeida@sapo.pt> (Vasco Almeida's message of "Fri, 8 Apr 2016 20:02:41 +0000")

Vasco Almeida <vascomalmeida@sapo.pt> writes:

> +		gettextln "You are not currently on a branch."
> +		if test $op_type = "rebase"

	if test "$op_type" = rebase

that is, $op_type could be an empty string that 'test' may not even
see hence it should be double-quoted to ensure 'test' sees an empty
string in that case, while "rebase" cannot be an empty string by
definition so there is no need to quote it.

Thanks.

  reply	other threads:[~2016-04-08 20:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 20:02 [PATCH 1/7] l10n: index-pack: use plural string instead of normal one Vasco Almeida
2016-04-08 20:02 ` [PATCH 2/7] l10n: unpack-trees: mark strings for translation Vasco Almeida
2016-04-08 20:23   ` Junio C Hamano
2016-04-09 12:19     ` Vasco Almeida
2016-04-08 20:02 ` [PATCH 3/7] l10n: git-parse-remote.sh: " Vasco Almeida
2016-04-08 20:30   ` Junio C Hamano [this message]
2016-04-08 20:02 ` [PATCH 4/7] l10n: builtin/pull.c: " Vasco Almeida
2016-04-08 20:33   ` Junio C Hamano
2016-04-09 12:34     ` Vasco Almeida
2016-04-08 20:02 ` [PATCH 5/7] l10n: builtin/pull.c: split strings marked " Vasco Almeida
2016-04-08 20:02 ` [PATCH 6/7] l10n: mv.c: add a comma ',' to string Vasco Almeida
2016-04-08 20:35   ` Junio C Hamano
2016-04-08 20:02 ` [PATCH 7/7] l10n: builtin/branch.c: mark option for translation Vasco Almeida
2016-04-08 20:26 ` [PATCH 1/7] l10n: index-pack: use plural string instead of normal one Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh9fbvo6d.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vascomalmeida@sapo.pt \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.