From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Jens Lehmann <jens.lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>,
"W. Trevor King" <wking@tremily.us>,
Eric Sunshine <sunshine@sunshineco.com>,
Karsten Blees <karsten.blees@gmail.com>
Subject: Re: [PATCH v5 0/4] submodule config lookup API
Date: Wed, 12 Aug 2015 10:53:58 -0700 [thread overview]
Message-ID: <xmqqio8kl7ex.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kakGg6Ejworq5xVr2QuzLHxh=E6tzU_PoW+0M6AWuKJfg@mail.gmail.com> (Stefan Beller's message of "Mon, 10 Aug 2015 12:23:08 -0700")
Stefan Beller <sbeller@google.com> writes:
> On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Thanks. Will replace and wait for comments from others.
>
> I have reviewed the patches carefully and they look good to me.
OK, I recall there were a few iterations with review comments before
this round. Is it your impression that they have been addressed
adequately?
Do you prefer it to be rebased to a more recent 'master' before you
build your work on top of it (I think the topic currently builds on
top of v2.5.0-rc0~56)?
Thanks.
next prev parent reply other threads:[~2015-08-12 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 21:06 [PATCH v5 0/4] submodule config lookup API Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values Heiko Voigt
2015-06-16 10:54 ` Heiko Voigt
2015-07-08 20:52 ` Phil Hord
2015-07-09 12:09 ` Heiko Voigt
2015-07-09 15:49 ` Jeff King
2015-07-09 19:41 ` Jens Lehmann
2015-07-09 20:00 ` Junio C Hamano
2015-07-13 11:17 ` Heiko Voigt
2015-07-13 15:49 ` Junio C Hamano
2015-06-15 21:06 ` [PATCH v5 2/4] extract functions for submodule config set and lookup Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 3/4] use new config API for worktree configurations of submodules Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 4/4] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
2015-06-15 21:48 ` [PATCH v5 0/4] submodule config lookup API Junio C Hamano
2015-08-10 19:23 ` Stefan Beller
2015-08-12 17:53 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-12 19:13 Stefan Beller
2015-08-12 19:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqio8kl7ex.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=jrnieder@gmail.com \
--cc=karsten.blees@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.