From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Jeff King <peff@peff.net>, Heiko Voigt <hvoigt@hvoigt.net>,
Phil Hord <phil.hord@gmail.com>, Git <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
"W. Trevor King" <wking@tremily.us>,
Karsten Blees <karsten.blees@gmail.com>
Subject: Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values
Date: Thu, 09 Jul 2015 13:00:10 -0700 [thread overview]
Message-ID: <xmqqoajlumnp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <559ECE6A.2070802@web.de> (Jens Lehmann's message of "Thu, 9 Jul 2015 21:41:30 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
>> How does git-submodule access this information? It looks like it just
>> hits "git config -f .gitmodules" directly. Perhaps whatever interface is
>> designed should be suitable for its use here (and if there really is no
>> more interesting interface needed, then why is "git config" not good
>> enough for other callers?).
>
> The git-submodule script doesn't need this and is fine using plain old
> "git config", as by the time it is run the .gitmodules file is already
> updated in the work tree. Heiko's series is about adding infrastructure
> to allow builtins like checkout and friends to access the configuration
> values from the .gitmodules file of the to-be-checked-out commit when
> run with "--recurse-submodules". And yes, if we want to expose this
> functionality to users or scripts some day "git config" looks like the
> best place to do that to me too.
Did you mean "git submodule config"?
next prev parent reply other threads:[~2015-07-09 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 21:06 [PATCH v5 0/4] submodule config lookup API Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values Heiko Voigt
2015-06-16 10:54 ` Heiko Voigt
2015-07-08 20:52 ` Phil Hord
2015-07-09 12:09 ` Heiko Voigt
2015-07-09 15:49 ` Jeff King
2015-07-09 19:41 ` Jens Lehmann
2015-07-09 20:00 ` Junio C Hamano [this message]
2015-07-13 11:17 ` Heiko Voigt
2015-07-13 15:49 ` Junio C Hamano
2015-06-15 21:06 ` [PATCH v5 2/4] extract functions for submodule config set and lookup Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 3/4] use new config API for worktree configurations of submodules Heiko Voigt
2015-06-15 21:06 ` [PATCH v5 4/4] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
2015-06-15 21:48 ` [PATCH v5 0/4] submodule config lookup API Junio C Hamano
2015-08-10 19:23 ` Stefan Beller
2015-08-12 17:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoajlumnp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=karsten.blees@gmail.com \
--cc=peff@peff.net \
--cc=phil.hord@gmail.com \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.