From: Junio C Hamano <gitster@pobox.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: Raj Ojha via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Raj Ojha <rajojha047@gmail.com>
Subject: Re: [PATCH] describe: use Q_() for pluralization of commit and tag counts
Date: Sat, 17 Oct 2026 09:27:05 -0700 [thread overview]
Message-ID: <xmqqmrscb8di.fsf@gitster.g> (raw)
In-Reply-To: <atNHlNl9mpDqUKb6@ugly.lan> (Oswald Buddenhagen's message of "Sat, 17 Oct 2026 12:01:56 +0200")
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> On Thu, Oct 15, 2026 at 09:54:29AM +0000, Raj Ojha via GitGitGadget wrote:
>>In `describe_commit()`, debug messages print the number of commits
>>traversed and the number of candidate tags found using basic `_()`
>>localization format strings:
>>
>> _("traversed %lu commits\n")
>> _("found %i tags; gave up search at %s\n")
>>
> i wonder why _debug_ messages are i18n'd in the first place? their
> target audience would usually be the git developers. or is this just a
> misnomer?
Funny that great minds think alike.
https://lore.kernel.org/git/20261014092923.GA1344504@coredump.intra.peff.net/
which led to
https://lore.kernel.org/git/20261016185418.162998-1-antekborowski11@gmail.com/
;-)
prev parent reply other threads:[~2026-10-17 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 9:54 [PATCH] describe: use Q_() for pluralization of commit and tag counts Raj Ojha via GitGitGadget
2026-10-16 15:51 ` Junio C Hamano
2026-10-17 10:01 ` Oswald Buddenhagen
2026-10-17 16:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmrscb8di.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=oswald.buddenhagen@gmx.de \
--cc=rajojha047@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.