All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Patrick Steinhardt <ps@pks.im>,
	 Josh Steadmon <steadmon@google.com>,
	git@vger.kernel.org,  karthik nayak <karthik.188@gmail.com>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 James Liu <james@jamesliu.io>
Subject: Re: [PATCH v4 3/3] refs/reftable: reload locked stack when preparing transaction
Date: Tue, 01 Oct 2024 16:24:50 -0700	[thread overview]
Message-ID: <xmqqttdvqud9.fsf@gitster.g> (raw)
In-Reply-To: <20241001225425.GB2317071@coredump.intra.peff.net> (Jeff King's message of "Tue, 1 Oct 2024 18:54:25 -0400")

Jeff King <peff@peff.net> writes:

> On Tue, Oct 01, 2024 at 06:27:33AM +0200, Patrick Steinhardt wrote:
>
>> If this is causing problems for folks I'd say we can do the below change
>> for now. It's of course only a stop-gap solution until I find the time
>> to debug this, which should be later this week or early next week.
>> 
>> Patrick
>> 
>> diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
>> index 2d951c8ceb..ad7bb39b79 100755
>> --- a/t/t0610-reftable-basics.sh
>> +++ b/t/t0610-reftable-basics.sh
>> @@ -450,7 +450,7 @@ test_expect_success 'ref transaction: retry acquiring tables.list lock' '
>>  	)
>>  '
>>  
>> -test_expect_success 'ref transaction: many concurrent writers' '
>> +test_expect_success !WINDOWS 'ref transaction: many concurrent writers' '
>>  	test_when_finished "rm -rf repo" &&
>>  	git init repo &&
>>  	(
>
> IMHO we can live with a flaky test for a little while. It's not like
> it's the only one. ;) And hopefully your digging turns up a real
> solution.
>
> It also sounds from subsequent discussion that Josh's issue was on
> Linux, so it wouldn't help there.

That's true.  WINDOWS prereq would not help there, even though it
would hide the breakage from CI.




  reply	other threads:[~2024-10-01 23:24 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17 13:43 [PATCH 0/3] reftable: graceful concurrent writes Patrick Steinhardt
2024-09-17 13:43 ` [PATCH 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-17 17:46   ` karthik nayak
2024-09-17 17:50     ` Eric Sunshine
2024-09-18  4:31       ` Patrick Steinhardt
2024-09-18  4:31     ` Patrick Steinhardt
2024-09-17 13:43 ` [PATCH 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-17 13:43 ` [PATCH 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-17 18:26 ` [PATCH 0/3] reftable: graceful concurrent writes karthik nayak
2024-09-18  4:31   ` Patrick Steinhardt
2024-09-18  4:32 ` [PATCH v2 " Patrick Steinhardt
2024-09-18  4:32   ` [PATCH v2 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-18  9:22     ` James Liu
2024-09-18  9:39       ` Patrick Steinhardt
2024-09-18  4:32   ` [PATCH v2 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-18  9:26     ` James Liu
2024-09-18  9:39       ` Patrick Steinhardt
2024-09-18  4:32   ` [PATCH v2 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-18  9:33   ` [PATCH v2 0/3] reftable: graceful concurrent writes James Liu
2024-09-18  9:59 ` [PATCH v3 " Patrick Steinhardt
2024-09-18  9:59   ` [PATCH v3 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-19 21:34     ` Junio C Hamano
2024-09-18  9:59   ` [PATCH v3 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-20 18:10     ` Junio C Hamano
2024-09-24  5:33       ` Patrick Steinhardt
2024-09-18  9:59   ` [PATCH v3 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-18 23:23   ` [PATCH v3 0/3] reftable: graceful concurrent writes James Liu
2024-09-24  5:33     ` Patrick Steinhardt
2024-09-24  5:32 ` [PATCH v4 " Patrick Steinhardt
2024-09-24  5:33   ` [PATCH v4 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-24  5:33   ` [PATCH v4 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-24  5:33   ` [PATCH v4 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-27  4:07     ` Jeff King
2024-09-30  6:49       ` Patrick Steinhardt
2024-09-30 22:19       ` Josh Steadmon
2024-10-01  4:27         ` Patrick Steinhardt
2024-10-01 22:54           ` Jeff King
2024-10-01 23:24             ` Junio C Hamano [this message]
2024-10-02 10:58               ` Patrick Steinhardt
2024-10-01  7:34         ` Junio C Hamano
2024-10-01 18:53           ` Josh Steadmon
2024-10-01 19:08             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttdvqud9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=james@jamesliu.io \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=steadmon@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.