From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de, hvoigt@hvoigt.net
Subject: Re: [PATCH 4/7] submodule: Allow errornous values for the fetchrecursesubmodules option
Date: Wed, 19 Aug 2015 11:09:38 -0700 [thread overview]
Message-ID: <xmqqtwrv9ml9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1439857323-21048-5-git-send-email-sbeller@google.com> (Stefan Beller's message of "Mon, 17 Aug 2015 17:22:00 -0700")
Stefan Beller <sbeller@google.com> writes:
> From: Heiko Voigt <hvoigt@hvoigt.net>
>
> We should not die when reading the submodule config cache since the user
> might not be able to get out of that situation when the configuration is
> part of the history.
>
> We should handle this condition later when the value is about to be
> used.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
The retitle is good but we'd need to typofix erroneous there, I
think (will do so while queuing, no need to resend).
next prev parent reply other threads:[~2015-08-19 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 0:21 [PATCH 0/7] Submodule improvements Stefan Beller
2015-08-18 0:21 ` [PATCH 1/7] submodule: implement a config API for lookup of .gitmodules values Stefan Beller
2015-08-18 0:21 ` [PATCH 2/7] submodule: extract functions for config set and lookup Stefan Beller
2015-08-18 0:21 ` [PATCH 3/7] submodule: use new config API for worktree configurations Stefan Beller
2015-08-18 0:22 ` [PATCH 4/7] submodule: Allow errornous values for the fetchrecursesubmodules option Stefan Beller
2015-08-19 18:09 ` Junio C Hamano [this message]
2015-08-18 0:22 ` [PATCH 5/7] submodule: implement `module_list` as a builtin helper Stefan Beller
2015-08-19 18:17 ` Junio C Hamano
2015-08-19 18:22 ` Junio C Hamano
2015-08-19 18:25 ` Stefan Beller
2015-08-19 18:23 ` Stefan Beller
2015-08-18 0:22 ` [PATCH 6/7] submodule: implement `module_name` " Stefan Beller
2015-08-18 0:22 ` [PATCH 7/7] submodule: implement `module_clone` " Stefan Beller
2015-08-18 0:26 ` Stefan Beller
2015-08-18 22:13 ` Stefan Beller
2015-08-19 19:08 ` Junio C Hamano
2015-08-19 19:20 ` Stefan Beller
2015-08-21 14:22 ` Jeff King
2015-08-18 0:38 ` [PATCH 0/7] Submodule improvements Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwrv9ml9.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.