Re: [PATCH 7/7] submodule: implement `module_clone` as a builtin helper

[Junio C Hamano <gitster@pobox.com>]

Stefan Beller <sbeller@google.com> writes:

> `module_clone` is part of the update command, which I want to convert
> to C next.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>
> This is the only patch that broke by a last minute fix,
> so this replaces the previous PATCH 7/7.

... which still breaks 7400.82, though.

Output from running it with "-i -v" ends like this:

expecting success: 
        mkdir super &&
        pwd=$(pwd) &&
        (
                cd super &&
                git init &&
                git submodule add --depth=1 file://"$pwd"/example2 submodule &&
                (
                        cd submodule &&
                        test 1 = $(git log --oneline | wc -l)
                )
        )

Initialized empty Git repository in /home/gitster/w/git.git/t/trash directory.t7400-submodule-basic/super/.git/
fatal: Clone of 'file:///home/gitster/w/git.git/t/trash directory.t7400-submodule-basic/example2' into submodule path 'submodule' failed
not ok 82 - submodule add clone shallow submodule
#
#               mkdir super &&
#               pwd=$(pwd) &&
#               (
#                       cd super &&
#                       git init &&
#                       git submodule add --depth=1 file://"$pwd"/example2 submodule &&
#                       (
#                               cd submodule &&
#                               test 1 = $(git log --oneline | wc -l)
#                       )
#               )
#