All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, luke@diamand.org
Subject: Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X
Date: Sun, 04 Oct 2015 11:49:07 -0700	[thread overview]
Message-ID: <xmqqwpv2zcyk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <E363C89B-7039-49F6-B723-8609DBAF2C64@gmail.com> (Lars Schneider's message of "Sun, 4 Oct 2015 11:38:31 -0700")

Lars Schneider <larsxschneider@gmail.com> writes:

> By the way... what formatting should I use?
>
> if foo
> then
>   bar
>
> or
>
> if foo; then
>   bar
>
> I think the latter is more used in the code base.

I've allowed the latter in fringe scripts (i.e. the ones that I do
not care too deeply) over time, but Documentation/CodingGuidelines
is very clear about it.

 - Do not write control structures on a single line with semicolon.

  reply	other threads:[~2015-10-04 18:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 18:06 [PATCH v2 0/4] Add Travis CI support larsxschneider
2015-10-04 18:06 ` [PATCH v2 1/4] " larsxschneider
2015-10-05  9:43   ` Johannes Schindelin
2015-10-04 18:06 ` [PATCH v2 2/4] Add prereq to detect OS X larsxschneider
2015-10-04 18:28   ` Junio C Hamano
2015-10-04 18:46     ` Lars Schneider
2015-10-04 18:06 ` [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on " larsxschneider
2015-10-04 18:23   ` Junio C Hamano
2015-10-04 18:44     ` Lars Schneider
2015-10-04 20:18       ` Pete Wyckoff
2015-10-05  3:08   ` Torsten Bögershausen
2015-10-04 18:06 ` [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test " larsxschneider
2015-10-04 18:26   ` Junio C Hamano
2015-10-04 18:38     ` Lars Schneider
2015-10-04 18:49       ` Junio C Hamano [this message]
2015-10-05  9:55 ` [PATCH v2 0/4] Add Travis CI support Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwpv2zcyk.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.