From: Junio C Hamano <gitster@pobox.com>
To: "Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Jeff King <peff@peff.net>, Justin Tobler <jltobler@gmail.com>,
Kristofer Karlsson <krka@spotify.com>
Subject: Re: [PATCH v3] odb: do not list our own refs as alternate refs
Date: Thu, 05 Nov 2026 11:07:25 -0800 [thread overview]
Message-ID: <xmqqy0b7t7v6.fsf@gitster.g> (raw)
In-Reply-To: <pull.2285.v3.git.1793864602482.gitgitgadget@gmail.com> (Kristofer Karlsson via GitGitGadget's message of "Thu, 05 Nov 2026 07:43:22 +0000")
"Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> Changes since v2:
>
> * Went back to the approach of v1, as Peff suggested: skip our own
> repository in the alternate refs code itself, with no special
> handling of the quarantine. The "borrowed" flag and the check for the
> parent of GIT_QUARANTINE_PATH are gone.
>
> * The commit message now describes this as a tightening of what
> --alternate-refs means, in line with how loading alternates already
> ignores the object directory itself.
>
> * Kept the documentation note and the tests from v2, except the one for
> a quarantine outside of the commondir.
Thanks. Will replace.
prev parent reply other threads:[~2026-11-05 19:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:18 [PATCH] odb: do not list our own refs as alternate refs in the quarantine Kristofer Karlsson via GitGitGadget
2026-10-29 16:57 ` Justin Tobler
2026-10-30 11:29 ` Kristofer Karlsson
2026-10-29 17:24 ` Junio C Hamano
2026-10-30 11:51 ` Kristofer Karlsson
2026-10-30 16:05 ` Junio C Hamano
2026-10-30 18:17 ` Jeff King
2026-11-02 11:45 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-11-03 0:37 ` Junio C Hamano
2026-11-03 1:12 ` Junio C Hamano
2026-11-03 10:19 ` Kristofer Karlsson
2026-11-03 11:00 ` Patrick Steinhardt
2026-11-03 12:05 ` Kristofer Karlsson
2026-11-03 12:26 ` Patrick Steinhardt
2026-11-03 21:53 ` Justin Tobler
2026-11-04 10:32 ` Kristofer Karlsson
2026-11-04 16:58 ` Justin Tobler
2026-11-04 2:48 ` Jeff King
2026-11-04 10:25 ` Kristofer Karlsson
2026-11-04 18:05 ` Junio C Hamano
2026-11-05 18:56 ` Jeff King
2026-11-05 19:56 ` Junio C Hamano
2026-11-05 7:43 ` [PATCH v3] odb: do not list our own refs as alternate refs Kristofer Karlsson via GitGitGadget
2026-11-05 19:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0b7t7v6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jltobler@gmail.com \
--cc=krka@spotify.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.