From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated
Date: Tue, 10 Sep 2013 08:59:34 -0700 [thread overview]
Message-ID: <xmqqy574zmzd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHGBnuN=vpJPXgd78aLohW3Awe+Y+0J7Bxwr4Fmn2NijMK1Z5g@mail.gmail.com> (Sebastian Schuberth's message of "Tue, 10 Sep 2013 10:06:37 +0200")
Sebastian Schuberth <sschuberth@gmail.com> writes:
> Right, but do we really need DEF_VER *and* version? Couldn't we just
> package official source tarballs in a way that they already contain an
> auto-generated version file?
If you read our Makefile, you will see that we do include the
version file in our official tarball with "make dist".
That however does not help those who use a tarball obtained from
git-archive, perhaps via gitweb running at the distribution site.
Theoretically speaking, you can rip out everything but "version" and
tell those who have been relying on the way other parts of G-V-G
worked to change their workflow to stuff their favorite version
string to that file before building, so in that sense, we do not
*need* DEF_VER and version. But they have been there for a long
time, and I do not think it gives us a good trade-off between
risking regression and reducing the linecount to change it to remove
one.
next prev parent reply other threads:[~2013-09-10 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 20:10 [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated Sebastian Schuberth
2013-09-06 21:40 ` Junio C Hamano
2013-09-07 0:37 ` Felipe Contreras
[not found] ` <CAJDDKr4JBeccwuD4PVq0ryO27Eyfz+yUAHT7xm0Dkh19SZpV4g@mail.gmail.com>
2013-09-08 0:58 ` Felipe Contreras
2013-09-07 12:28 ` Sebastian Schuberth
2013-09-07 16:10 ` Junio C Hamano
2013-09-07 19:47 ` Sebastian Schuberth
2013-09-08 17:41 ` Junio C Hamano
2013-09-09 23:21 ` Felipe Contreras
2013-09-10 8:06 ` Sebastian Schuberth
2013-09-10 9:53 ` Felipe Contreras
2013-09-10 15:59 ` Junio C Hamano [this message]
2013-09-10 19:45 ` Sebastian Schuberth
2013-09-08 0:54 ` Felipe Contreras
2013-09-06 22:34 ` Kyle J. McKay
2013-09-07 12:26 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy574zmzd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.