From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] i18n: notes: mark comment for translation
Date: Tue, 26 Jul 2016 09:57:34 -0700 [thread overview]
Message-ID: <xmqqzip41gn5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1469535400-9242-1-git-send-email-vascomalmeida@sapo.pt> (Vasco Almeida's message of "Tue, 26 Jul 2016 12:16:40 +0000")
Vasco Almeida <vascomalmeida@sapo.pt> writes:
> + strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
> + strbuf_add_commented_lines(&buf, _(note_template), strlen(_(note_template)));
> + strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
Hmm, do we really need to make three separate calls?
next prev parent reply other threads:[~2016-07-26 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 14:10 [PATCH v2] i18n: notes: mark comment for translation Vasco Almeida
2016-07-25 17:49 ` Junio C Hamano
2016-07-26 12:16 ` Vasco Almeida
2016-07-26 17:05 ` Junio C Hamano
2016-07-27 10:40 ` Vasco Almeida
2016-07-26 12:16 ` [PATCH v3] " Vasco Almeida
2016-07-26 16:57 ` Junio C Hamano [this message]
2016-07-27 10:53 ` Vasco Almeida
2016-07-27 19:33 ` Junio C Hamano
2016-07-28 11:26 ` [PATCH v4] " Vasco Almeida
2016-07-28 16:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzip41gn5.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=vascomalmeida@sapo.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.