* [PATCH] selftests/bpf: install generated test progs
@ 2020-05-13 2:17 Yauheni Kaliuta
2020-05-13 4:25 ` Andrii Nakryiko
2020-05-13 14:55 ` Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: Yauheni Kaliuta @ 2020-05-13 2:17 UTC (permalink / raw)
To: bpf; +Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
Before commit 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
test_maps w/ general rule") selftests/bpf used generic install
target from selftests/lib.mk to install generated bpf test progs by
mentioning them in TEST_GEN_FILES variable.
Take that functionality back.
Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
test_maps w/ general rule")
Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
tools/testing/selftests/bpf/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 7729892e0b04..c9a07cc7dede 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -263,6 +263,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS)
TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h, \
$$(filter-out $(SKEL_BLACKLIST), \
$$(TRUNNER_BPF_SRCS)))
+TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS)
# Evaluate rules now with extra TRUNNER_XXX variables above already defined
$$(eval $$(call DEFINE_TEST_RUNNER_RULES,$1,$2))
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/bpf: install generated test progs
2020-05-13 2:17 [PATCH] selftests/bpf: install generated test progs Yauheni Kaliuta
@ 2020-05-13 4:25 ` Andrii Nakryiko
2020-05-13 14:55 ` Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: Andrii Nakryiko @ 2020-05-13 4:25 UTC (permalink / raw)
To: Yauheni Kaliuta; +Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
On Tue, May 12, 2020 at 7:18 PM Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
>
> Before commit 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
> test_maps w/ general rule") selftests/bpf used generic install
> target from selftests/lib.mk to install generated bpf test progs by
> mentioning them in TEST_GEN_FILES variable.
>
> Take that functionality back.
>
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
> test_maps w/ general rule")
>
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
> ---
Thanks for fixing!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/testing/selftests/bpf/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 7729892e0b04..c9a07cc7dede 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -263,6 +263,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS)
> TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h, \
> $$(filter-out $(SKEL_BLACKLIST), \
> $$(TRUNNER_BPF_SRCS)))
> +TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS)
>
> # Evaluate rules now with extra TRUNNER_XXX variables above already defined
> $$(eval $$(call DEFINE_TEST_RUNNER_RULES,$1,$2))
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/bpf: install generated test progs
2020-05-13 2:17 [PATCH] selftests/bpf: install generated test progs Yauheni Kaliuta
2020-05-13 4:25 ` Andrii Nakryiko
@ 2020-05-13 14:55 ` Daniel Borkmann
2020-05-14 6:22 ` Yauheni Kaliuta
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2020-05-13 14:55 UTC (permalink / raw)
To: Yauheni Kaliuta, bpf; +Cc: Alexei Starovoitov, Andrii Nakryiko
On 5/13/20 4:17 AM, Yauheni Kaliuta wrote:
> Before commit 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
> test_maps w/ general rule") selftests/bpf used generic install
> target from selftests/lib.mk to install generated bpf test progs by
> mentioning them in TEST_GEN_FILES variable.
>
> Take that functionality back.
>
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and
> test_maps w/ general rule")
>
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-14 6:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-13 2:17 [PATCH] selftests/bpf: install generated test progs Yauheni Kaliuta
2020-05-13 4:25 ` Andrii Nakryiko
2020-05-13 14:55 ` Daniel Borkmann
2020-05-14 6:22 ` Yauheni Kaliuta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.