From: Vlad Buslov <vladbu@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dmytro Linkin <dlinkin@nvidia.com>, Roi Dayan <roid@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check
Date: Wed, 10 Feb 2021 11:40:31 +0000 [thread overview]
Message-ID: <ygnhczx8gngw.fsf@nvidia.com> (raw)
In-Reply-To: <YCO+NCjissLTG1H6@mwanda>
On Wed 10 Feb 2021 at 13:06, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The mlx5_chains_get_table() function doesn't return NULL, it returns
> error pointers so we need to fix this condition.
>
> Fixes: 34ca65352ddf ("net/mlx5: E-Switch, Indirect table infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Dan!
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Buslov <vladbu@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dmytro Linkin <dlinkin@nvidia.com>, Roi Dayan <roid@nvidia.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check
Date: Wed, 10 Feb 2021 13:40:31 +0200 [thread overview]
Message-ID: <ygnhczx8gngw.fsf@nvidia.com> (raw)
In-Reply-To: <YCO+NCjissLTG1H6@mwanda>
On Wed 10 Feb 2021 at 13:06, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The mlx5_chains_get_table() function doesn't return NULL, it returns
> error pointers so we need to fix this condition.
>
> Fixes: 34ca65352ddf ("net/mlx5: E-Switch, Indirect table infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Dan!
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
next prev parent reply other threads:[~2021-02-10 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 11:06 [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check Dan Carpenter
2021-02-10 11:06 ` Dan Carpenter
2021-02-10 11:40 ` Vlad Buslov [this message]
2021-02-10 11:40 ` Vlad Buslov
2021-02-11 4:17 ` Saeed Mahameed
2021-02-11 4:17 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ygnhczx8gngw.fsf@nvidia.com \
--to=vladbu@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dlinkin@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.