From: Jes Sorensen <jes@wildopensource.com>
To: linux-ia64@vger.kernel.org
Subject: Re: 2.6.13-rc5 does not boot on Tiger4
Date: Fri, 05 Aug 2005 17:49:37 +0000 [thread overview]
Message-ID: <yq0ek98ff4e.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <jeoe8fyrfb.fsf@sykes.suse.de>
>>>>> "Tony" = Luck, Tony <tony.luck@intel.com> writes:
>> + if (md->type = EFI_BOOT_SERVICES_DATA && + md->attribute =
>> EFI_MEMORY_UC) {
Tony> That will certainly stop this code from crashing on Tiger.
Tony> But it still doesn't really do what the comment claims it will
Tony> do. The "attribute" field is a bitmask ... most of the memory
Tony> that was dropped because of holes or incompatible attributes
Tony> within the same granule will also have other allowable
Tony> attributes. So final version of this should be checking
Tony> "md->attribute & EFI_MEMORY_UC" rather than "=".
Ok,
I don't have all the EFI specs at hand, didn't realize it was a
bitmask. We should probably combine that with something like what Alex
Williamson was suggesting.
Cheers,
Jes
next prev parent reply other threads:[~2005-08-05 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 15:24 2.6.13-rc5 does not boot on Tiger4 Andreas Schwab
2005-08-03 17:17 ` Luck, Tony
2005-08-03 17:25 ` Luck, Tony
2005-08-04 1:42 ` Peter Chubb
2005-08-04 2:09 ` Keith Owens
2005-08-04 4:08 ` Peter Chubb
2005-08-04 4:24 ` Alex Williamson
2005-08-04 16:27 ` Bjorn Helgaas
2005-08-04 16:48 ` Andreas Schwab
2005-08-04 17:55 ` Luck, Tony
2005-08-04 18:23 ` Jes Sorensen
2005-08-05 0:02 ` Luck, Tony
2005-08-05 9:57 ` Andreas Schwab
2005-08-05 14:12 ` Jes Sorensen
2005-08-05 17:00 ` Alex Williamson
2005-08-05 17:02 ` Alex Williamson
2005-08-05 17:20 ` Luck, Tony
2005-08-05 17:49 ` Jes Sorensen [this message]
2005-08-08 13:51 ` Jes Sorensen
2005-08-08 16:37 ` Luck, Tony
2005-08-09 9:51 ` Jes Sorensen
2005-08-09 17:00 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0ek98ff4e.fsf@jaguar.mkp.net \
--to=jes@wildopensource.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.