From: Jes Sorensen <jes@wildopensource.com>
To: linux-ia64@vger.kernel.org
Subject: Re: 2.6.13-rc5 does not boot on Tiger4
Date: Fri, 05 Aug 2005 14:12:58 +0000 [thread overview]
Message-ID: <yq0irykfp5h.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <jeoe8fyrfb.fsf@sykes.suse.de>
>>>>> "Tony" = Luck, Tony <tony.luck@intel.com> writes:
Tony> So it looks like your problem is
Tony> CONFIG_IA64_UNCACHED_ALLOCATOR=y
>> Impossible, thats my code! It can't be broken ;-)
>>
>> Anyone who have tried this on an ZX1 box? Otherwise I'll try it out
>> on my 2600 tomorrow and see if I can reproduce it.
Tony> It may help to know that on the tiger, efi_memmap_walk_uc
Tony> decides that this efi_memory_desc_t entry is fair game:
Tony> type = 11 (EFI_MEMORY_MAPPED_IO) phys_addr = 0xfe000000
Tony> num_pages = 0x1000 attribute = 0x1
Details, details ;-)
I think this patch should take care of it.
Cheers,
Jes
Only grab uncached pages from the boot services data section to avoid
grabbing memory mapped IO regions by mistake.
Signed-off-by: Jes Sorensen <jes@trained-monkey.org>
diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c
+++ b/arch/ia64/kernel/efi.c
@@ -431,7 +431,8 @@ efi_memmap_walk_uc (efi_freemem_callback
for (p = efi_map_start; p < efi_map_end; p += efi_desc_size) {
md = p;
- if (md->attribute = EFI_MEMORY_UC) {
+ if (md->type = EFI_BOOT_SERVICES_DATA &&
+ md->attribute = EFI_MEMORY_UC) {
start = PAGE_ALIGN(md->phys_addr);
end = PAGE_ALIGN((md->phys_addr+(md->num_pages << EFI_PAGE_SHIFT)) & PAGE_MASK);
if ((*callback)(start, end, NULL) < 0)
next prev parent reply other threads:[~2005-08-05 14:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 15:24 2.6.13-rc5 does not boot on Tiger4 Andreas Schwab
2005-08-03 17:17 ` Luck, Tony
2005-08-03 17:25 ` Luck, Tony
2005-08-04 1:42 ` Peter Chubb
2005-08-04 2:09 ` Keith Owens
2005-08-04 4:08 ` Peter Chubb
2005-08-04 4:24 ` Alex Williamson
2005-08-04 16:27 ` Bjorn Helgaas
2005-08-04 16:48 ` Andreas Schwab
2005-08-04 17:55 ` Luck, Tony
2005-08-04 18:23 ` Jes Sorensen
2005-08-05 0:02 ` Luck, Tony
2005-08-05 9:57 ` Andreas Schwab
2005-08-05 14:12 ` Jes Sorensen [this message]
2005-08-05 17:00 ` Alex Williamson
2005-08-05 17:02 ` Alex Williamson
2005-08-05 17:20 ` Luck, Tony
2005-08-05 17:49 ` Jes Sorensen
2005-08-08 13:51 ` Jes Sorensen
2005-08-08 16:37 ` Luck, Tony
2005-08-09 9:51 ` Jes Sorensen
2005-08-09 17:00 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0irykfp5h.fsf@jaguar.mkp.net \
--to=jes@wildopensource.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.