Re: [patch] 2.6.1-mm5 compile do not use shared extable code for ia64

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Jes Sorensen <jes@wildopensource.com>
To: davidm@hpl.hp.com
Cc: Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.6.1-mm5 compile do not use shared extable code for ia64
Date: Tue, 27 Jan 2004 08:11:03 +0000	[thread overview]
Message-ID: <yq0y8rtreug.fsf@wildopensource.com> (raw)
In-Reply-To: <16405.41953.344071.456754@napali.hpl.hp.com>

>>>>> "David" = David Mosberger <davidm@napali.hpl.hp.com> writes:

David,

I am just nitpicking here, but wouldn't it be better to stick to the
convention of all upper case defines for the #ifdef check?

Maybe use something like?
#define ARCH_EXTABLE_COMPARE_ENTRIES ia64_extable_compare_entries

Cheers,
Jes


@@ -18,7 +18,25 @@
 extern struct exception_table_entry __start___ex_table[];
 extern struct exception_table_entry __stop___ex_table[];
 
-#ifndef ARCH_HAS_SORT_EXTABLE
+#ifndef extable_compare_entries
+
+/*
+ * Compare exception-table entries L and R and return <0 if L is smaller, 0 if L and R are
+ * equal and >0 if L is bigger.
+ */

WARNING: multiple messages have this Message-ID (diff)

From: Jes Sorensen <jes@wildopensource.com>
To: davidm@hpl.hp.com
Cc: Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.6.1-mm5 compile do not use shared extable code for ia64
Date: 27 Jan 2004 03:11:03 -0500	[thread overview]
Message-ID: <yq0y8rtreug.fsf@wildopensource.com> (raw)
In-Reply-To: <16405.41953.344071.456754@napali.hpl.hp.com>

>>>>> "David" == David Mosberger <davidm@napali.hpl.hp.com> writes:

David,

I am just nitpicking here, but wouldn't it be better to stick to the
convention of all upper case defines for the #ifdef check?

Maybe use something like?
#define ARCH_EXTABLE_COMPARE_ENTRIES ia64_extable_compare_entries

Cheers,
Jes


@@ -18,7 +18,25 @@
 extern struct exception_table_entry __start___ex_table[];
 extern struct exception_table_entry __stop___ex_table[];
 
-#ifndef ARCH_HAS_SORT_EXTABLE
+#ifndef extable_compare_entries
+
+/*
+ * Compare exception-table entries L and R and return <0 if L is smaller, 0 if L and R are
+ * equal and >0 if L is bigger.
+ */

next prev parent reply	other threads:[~2004-01-27  8:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-20 12:23 [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Jes Sorensen
2004-01-20 12:23 ` Jes Sorensen
2004-01-20 17:00 ` [patch] 2.6.1-mm5 compile do not use shared extable code for Andrew Morton
2004-01-20 17:00   ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Andrew Morton
2004-01-24  3:00   ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-24  3:00     ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
2004-01-24 10:49     ` [patch] 2.6.1-mm5 compile do not use shared extable code for Paul Mackerras
2004-01-24 10:49       ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Paul Mackerras
2004-01-26 23:33       ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-26 23:33         ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
2004-01-27  8:11         ` Jes Sorensen [this message]
2004-01-27  8:11           ` Jes Sorensen
2004-01-27 17:39           ` David Mosberger
2004-01-27 17:39             ` David Mosberger
2004-01-27  8:56         ` [patch] 2.6.1-mm5 compile do not use shared extable code for Paul Mackerras
2004-01-27  8:56           ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Paul Mackerras
2004-01-27 16:19           ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-27 16:19             ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
2004-01-27 23:49             ` [patch] 2.6.1-mm5 compile do not use shared extable code for Paul Mackerras
2004-01-27 23:49               ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Paul Mackerras
2004-01-28  6:06               ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-28  6:06                 ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
2004-01-27 17:54           ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-27 17:54             ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
2004-01-21 18:43 ` David Mosberger
2004-01-21 18:43   ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq0y8rtreug.fsf@wildopensource.com \
    --to=jes@wildopensource.com \
    --cc=akpm@osdl.org \
    --cc=davidm@hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.