From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Disseldorp <ddiss@suse.de>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, bvanassche@acm.org
Subject: Re: [PATCH v3 0/5] scsi: target: XCOPY performance
Date: Fri, 27 Mar 2020 13:49:52 -0400 [thread overview]
Message-ID: <yq11rpdbscf.fsf@oracle.com> (raw)
In-Reply-To: <20200327141954.955-1-ddiss@suse.de> (David Disseldorp's message of "Fri, 27 Mar 2020 15:19:49 +0100")
David,
> These changes remove unnecessary heap allocations in the XCOPY
> READ/WRITE dispatch loop.
>
> Synthetic benchmarks on my laptop using the libiscsi iscsi-dd utility
> (--xcopy --max 1 --blocks 65535 src=dst) against a target backed by an
> 8G zram (DEBUG_KMEMLEAK=y) iblock backstore (avg across four runs) show:
> before: 5.30845G/s
> after: 5.99056G/s (approx. +12.8%)
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Disseldorp <ddiss@suse.de>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, bvanassche@acm.org
Subject: Re: [PATCH v3 0/5] scsi: target: XCOPY performance
Date: Fri, 27 Mar 2020 17:49:52 +0000 [thread overview]
Message-ID: <yq11rpdbscf.fsf@oracle.com> (raw)
In-Reply-To: <20200327141954.955-1-ddiss@suse.de> (David Disseldorp's message of "Fri, 27 Mar 2020 15:19:49 +0100")
David,
> These changes remove unnecessary heap allocations in the XCOPY
> READ/WRITE dispatch loop.
>
> Synthetic benchmarks on my laptop using the libiscsi iscsi-dd utility
> (--xcopy --max 1 --blocks 65535 src=dst) against a target backed by an
> 8G zram (DEBUG_KMEMLEAK=y) iblock backstore (avg across four runs) show:
> before: 5.30845G/s
> after: 5.99056G/s (approx. +12.8%)
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-03-27 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:19 [PATCH v3 0/5] scsi: target: XCOPY performance David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 14:19 ` [PATCH v3 1/5] scsi: target: use #def for xcopy descriptor len David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 14:19 ` [PATCH v3 2/5] scsi: target: drop xcopy DISK BLOCK LENGTH debug David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 14:19 ` [PATCH v3 3/5] scsi: target: avoid per-loop XCOPY buffer allocations David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 14:19 ` [PATCH v3 4/5] scsi: target: increase XCOPY I/O size David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 14:19 ` [PATCH v3 5/5] scsi: target: use the stack for XCOPY passthrough cmds David Disseldorp
2020-03-27 14:19 ` David Disseldorp
2020-03-27 17:49 ` Martin K. Petersen [this message]
2020-03-27 17:49 ` [PATCH v3 0/5] scsi: target: XCOPY performance Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11rpdbscf.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=ddiss@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.