From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-scsi@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones()
Date: Thu, 11 Jul 2019 20:24:18 -0400 [thread overview]
Message-ID: <yq11ryw9k25.fsf@oracle.com> (raw)
In-Reply-To: <20190701050918.27511-3-damien.lemoal@wdc.com> (Damien Le Moal's message of "Mon, 1 Jul 2019 14:09:16 +0900")
Damien,
> Only GFP_KERNEL and GFP_NOIO are used with blkdev_report_zones(). In
> preparation of using vmalloc() for large report buffer and zone array
> allocations used by this function, remove its "gfp_t gfp_mask" argument
> and rely on the caller context to use memalloc_noio_save/restore() where
> necessary (block layer zone revalidation and dm-zoned I/O error path).
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones()
Date: Thu, 11 Jul 2019 20:24:18 -0400 [thread overview]
Message-ID: <yq11ryw9k25.fsf@oracle.com> (raw)
In-Reply-To: <20190701050918.27511-3-damien.lemoal@wdc.com> (Damien Le Moal's message of "Mon, 1 Jul 2019 14:09:16 +0900")
Damien,
> Only GFP_KERNEL and GFP_NOIO are used with blkdev_report_zones(). In
> preparation of using vmalloc() for large report buffer and zone array
> allocations used by this function, remove its "gfp_t gfp_mask" argument
> and rely on the caller context to use memalloc_noio_save/restore() where
> necessary (block layer zone revalidation and dm-zoned I/O error path).
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-scsi@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [f2fs-dev] [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones()
Date: Thu, 11 Jul 2019 20:24:18 -0400 [thread overview]
Message-ID: <yq11ryw9k25.fsf@oracle.com> (raw)
In-Reply-To: <20190701050918.27511-3-damien.lemoal@wdc.com> (Damien Le Moal's message of "Mon, 1 Jul 2019 14:09:16 +0900")
Damien,
> Only GFP_KERNEL and GFP_NOIO are used with blkdev_report_zones(). In
> preparation of using vmalloc() for large report buffer and zone array
> allocations used by this function, remove its "gfp_t gfp_mask" argument
> and rely on the caller context to use memalloc_noio_save/restore() where
> necessary (block layer zone revalidation and dm-zoned I/O error path).
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-07-12 0:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 5:09 [PATCH V6 0/4] Fix zone revalidation memory allocation failures Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] " Damien Le Moal
2019-07-01 5:09 ` [PATCH V6 1/4] block: Allow mapping of vmalloc-ed buffers Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] " Damien Le Moal
2019-07-01 6:16 ` Christoph Hellwig
2019-07-01 6:16 ` [f2fs-dev] " Christoph Hellwig
2019-07-01 6:16 ` Christoph Hellwig
2019-07-12 0:22 ` Martin K. Petersen
2019-07-12 0:22 ` [f2fs-dev] " Martin K. Petersen
2019-07-12 0:22 ` Martin K. Petersen
2019-07-01 5:09 ` [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones() Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] " Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-01 6:17 ` [f2fs-dev] " Christoph Hellwig
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:24 ` Martin K. Petersen [this message]
2019-07-12 0:24 ` [f2fs-dev] " Martin K. Petersen
2019-07-12 0:24 ` Martin K. Petersen
2019-07-01 5:09 ` [PATCH V6 3/4] sd_zbc: Fix report zones buffer allocation Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] " Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-01 6:17 ` [f2fs-dev] " Christoph Hellwig
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:27 ` Martin K. Petersen
2019-07-12 0:27 ` [f2fs-dev] " Martin K. Petersen
2019-07-12 0:27 ` Martin K. Petersen
2019-07-12 0:52 ` Damien Le Moal
2019-07-12 0:52 ` [f2fs-dev] " Damien Le Moal
2019-07-12 0:52 ` Damien Le Moal
2019-07-01 5:09 ` [PATCH V6 4/4] block: Limit zone array allocation size Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] " Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-01 6:17 ` [f2fs-dev] " Christoph Hellwig
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:28 ` Martin K. Petersen
2019-07-12 0:28 ` [f2fs-dev] " Martin K. Petersen
2019-07-12 0:28 ` Martin K. Petersen
2019-07-08 2:02 ` [PATCH V6 0/4] Fix zone revalidation memory allocation failures Damien Le Moal
2019-07-08 2:02 ` [f2fs-dev] " Damien Le Moal
2019-07-12 2:05 ` Jens Axboe
2019-07-12 2:05 ` [f2fs-dev] " Jens Axboe
2019-07-12 15:12 ` Jens Axboe
2019-07-12 15:12 ` [f2fs-dev] " Jens Axboe
2019-07-12 22:33 ` Damien Le Moal
2019-07-12 22:33 ` [f2fs-dev] " Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11ryw9k25.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.