From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: james.bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, brking@linux.vnet.ibm.com,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal
Date: Wed, 20 Mar 2019 20:14:13 -0400 [thread overview]
Message-ID: <yq11s316q3u.fsf@oracle.com> (raw)
In-Reply-To: <20190320184151.31321-2-tyreld@linux.vnet.ibm.com> (Tyrel Datwyler's message of "Wed, 20 Mar 2019 13:41:51 -0500")
Tyrel,
> The event pool used for queueing commands is destroyed fairly early in
> the ibmvscsi_remove() code path. Since, this happens prior to the call
> so scsi_remove_host() it is possible for further calls to queuecommand
> to be processed which manifest as a panic due to a NULL pointer
> dereference as seen here:
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
stable@vger.kernel.org, james.bottomley@hansenpartnership.com,
brking@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal
Date: Wed, 20 Mar 2019 20:14:13 -0400 [thread overview]
Message-ID: <yq11s316q3u.fsf@oracle.com> (raw)
In-Reply-To: <20190320184151.31321-2-tyreld@linux.vnet.ibm.com> (Tyrel Datwyler's message of "Wed, 20 Mar 2019 13:41:51 -0500")
Tyrel,
> The event pool used for queueing commands is destroyed fairly early in
> the ibmvscsi_remove() code path. Since, this happens prior to the call
> so scsi_remove_host() it is possible for further calls to queuecommand
> to be processed which manifest as a panic due to a NULL pointer
> dereference as seen here:
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-03-21 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:41 [PATCH 1/2] ibmvscsi: Protect ibmvscsi_head from concurrent modificaiton Tyrel Datwyler
2019-03-20 18:41 ` Tyrel Datwyler
2019-03-20 18:41 ` [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal Tyrel Datwyler
2019-03-20 18:41 ` Tyrel Datwyler
2019-03-21 0:14 ` Martin K. Petersen [this message]
2019-03-21 0:14 ` Martin K. Petersen
2019-03-21 0:13 ` [PATCH 1/2] ibmvscsi: Protect ibmvscsi_head from concurrent modificaiton Martin K. Petersen
2019-03-21 0:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11s316q3u.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@linux.vnet.ibm.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.