From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
jejb@linux.vnet.ibm.com, linuxarm@huawei.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw
Date: Mon, 17 Dec 2018 22:31:02 -0500 [thread overview]
Message-ID: <yq11s6flde1.fsf@oracle.com> (raw)
In-Reply-To: <afb32599-9b81-9d56-3ae7-2797992353a1@huawei.com> (John Garry's message of "Mon, 17 Dec 2018 14:51:36 +0000")
John,
> We have an issue with using scsi_transfer_length().
>
> As I understand, for our controller we need to set the host structure
> data transfer size to the size of data to write to the disk for WRITE
> type command, and at size of info received to host memory for READ
> type command. As such, for READ STRIP, we only want the SCSI buf len,
> and not the scsi buf len and PI (this is what scsi_transfer_length()
> provides).
Interesting asymmetry.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
<jejb@linux.vnet.ibm.com>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw
Date: Mon, 17 Dec 2018 22:31:02 -0500 [thread overview]
Message-ID: <yq11s6flde1.fsf@oracle.com> (raw)
In-Reply-To: <afb32599-9b81-9d56-3ae7-2797992353a1@huawei.com> (John Garry's message of "Mon, 17 Dec 2018 14:51:36 +0000")
John,
> We have an issue with using scsi_transfer_length().
>
> As I understand, for our controller we need to set the host structure
> data transfer size to the size of data to write to the disk for WRITE
> type command, and at size of info received to host memory for READ
> type command. As such, for READ STRIP, we only want the SCSI buf len,
> and not the scsi buf len and PI (this is what scsi_transfer_length()
> provides).
Interesting asymmetry.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-12-18 3:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:34 [PATCH v4 0/5] hisi_sas: DIF support John Garry
2018-12-06 13:34 ` John Garry
2018-12-06 13:34 ` [PATCH v4 1/5] scsi: hisi_sas: Fix warnings detected by sparse John Garry
2018-12-06 13:34 ` John Garry
2018-12-06 13:34 ` [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity John Garry
2018-12-06 13:34 ` John Garry
2018-12-06 14:17 ` Johannes Thumshirn
2018-12-06 15:37 ` John Garry
2018-12-06 15:37 ` John Garry
2018-12-06 16:20 ` Johannes Thumshirn
2018-12-07 10:07 ` John Garry
2018-12-07 10:07 ` John Garry
2018-12-07 10:53 ` Johannes Thumshirn
2018-12-06 13:34 ` [PATCH v4 3/5] scsi: hisi_sas: Make sg_tablesize consistent value John Garry
2018-12-06 13:34 ` John Garry
2018-12-06 13:34 ` [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw John Garry
2018-12-06 13:34 ` John Garry
2018-12-13 2:20 ` Martin K. Petersen
2018-12-13 2:20 ` Martin K. Petersen
2018-12-13 13:35 ` John Garry
2018-12-13 13:35 ` John Garry
2018-12-17 14:51 ` John Garry
2018-12-17 14:51 ` John Garry
2018-12-18 3:31 ` Martin K. Petersen [this message]
2018-12-18 3:31 ` Martin K. Petersen
2018-12-06 13:34 ` [RFC PATCH v4 5/5] scsi: hisi_sas: Add support for DIX feature for v3 hw as experimental John Garry
2018-12-06 13:34 ` John Garry
2018-12-13 2:23 ` [PATCH v4 0/5] hisi_sas: DIF support Martin K. Petersen
2018-12-13 2:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11s6flde1.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.