From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Jing Huang <huangj@brocade.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [SCSI] bfa: integer overflow in debugfs
Date: Tue, 17 Oct 2017 02:36:23 +0000 [thread overview]
Message-ID: <yq11sm233h4.fsf@oracle.com> (raw)
In-Reply-To: <20171004075037.j7pkdqqcegvba44e@mwanda> (Dan Carpenter's message of "Wed, 4 Oct 2017 10:50:37 +0300")
Dan,
> We could allocate less memory than intended because we do:
>
> bfad->regdata = kzalloc(len << 2, GFP_KERNEL);
>
> The shift can overflow leading to a crash. This is debugfs code so the
> impact is very small. I fixed the network version of this in March with
> commit 13e2d5187f6b ("bna: integer overflow bug in debugfs").
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Jing Huang <huangj@brocade.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [SCSI] bfa: integer overflow in debugfs
Date: Mon, 16 Oct 2017 22:36:23 -0400 [thread overview]
Message-ID: <yq11sm233h4.fsf@oracle.com> (raw)
In-Reply-To: <20171004075037.j7pkdqqcegvba44e@mwanda> (Dan Carpenter's message of "Wed, 4 Oct 2017 10:50:37 +0300")
Dan,
> We could allocate less memory than intended because we do:
>
> bfad->regdata = kzalloc(len << 2, GFP_KERNEL);
>
> The shift can overflow leading to a crash. This is debugfs code so the
> impact is very small. I fixed the network version of this in March with
> commit 13e2d5187f6b ("bna: integer overflow bug in debugfs").
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-10-17 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 7:50 [PATCH] [SCSI] bfa: integer overflow in debugfs Dan Carpenter
2017-10-04 7:50 ` Dan Carpenter
2017-10-17 2:36 ` Martin K. Petersen [this message]
2017-10-17 2:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11sm233h4.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=dan.carpenter@oracle.com \
--cc=huangj@brocade.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.