[PATCH v2 0/1] mpi3mr: Fix compilation errors on i386 arch

[PATCH v2 0/1] mpi3mr: Fix compilation errors on i386 arch

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Fix below compilation errors observed on i386 arch
with allyesconfig config

cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
and
cast to pointer from integer of different size

Sreekanth Reddy (1):
  mpi3mr: Fix compilation errors observed on i386 arch

 drivers/scsi/mpi3mr/mpi3mr_os.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

[PATCH v2 1/1] mpi3mr: Fix compilation errors observed on i386 arch

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

Fix below compilation errors observed on i386 ARCH,

cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]

Fixes: c196bc4dce ("scsi: mpi3mr: Reduce VD queue depth on detecting throttling")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpi3mr/mpi3mr_os.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index 0901bc932d5c..4102636df4fc 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -386,7 +386,7 @@ static void mpi3mr_queue_qd_reduction_event(struct mpi3mr_ioc *mrioc,
 		ioc_warn(mrioc, "failed to queue TG QD reduction event\n");
 		return;
 	}
-	*(__le64 *)fwevt->event_data = (__le64)tg;
+	*(struct mpi3mr_throttle_group_info **)fwevt->event_data = tg;
 	fwevt->mrioc = mrioc;
 	fwevt->event_id = MPI3MR_DRIVER_EVENT_TG_QD_REDUCTION;
 	fwevt->send_ack = 0;
@@ -1660,8 +1660,7 @@ static void mpi3mr_fwevt_bh(struct mpi3mr_ioc *mrioc,
 	{
 		struct mpi3mr_throttle_group_info *tg;
 
-		tg = (struct mpi3mr_throttle_group_info *)
-		    (*(__le64 *)fwevt->event_data);
+		tg = *(struct mpi3mr_throttle_group_info **)fwevt->event_data;
 		dprint_event_bh(mrioc,
 		    "qd reduction event processed for tg_id(%d) reduction_needed(%d)\n",
 		    tg->id, tg->need_qd_reduction);
-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH v2 1/1] mpi3mr: Fix compilation errors observed on i386 arch

[Guenter Roeck]

On Mon, Jul 18, 2022 at 03:23:51PM +0530, Sreekanth Reddy wrote:
> Fix below compilation errors observed on i386 ARCH,
> 
> cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
> 
> Fixes: c196bc4dce ("scsi: mpi3mr: Reduce VD queue depth on detecting throttling")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/scsi/mpi3mr/mpi3mr_os.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index 0901bc932d5c..4102636df4fc 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -386,7 +386,7 @@ static void mpi3mr_queue_qd_reduction_event(struct mpi3mr_ioc *mrioc,
>  		ioc_warn(mrioc, "failed to queue TG QD reduction event\n");
>  		return;
>  	}
> -	*(__le64 *)fwevt->event_data = (__le64)tg;
> +	*(struct mpi3mr_throttle_group_info **)fwevt->event_data = tg;
>  	fwevt->mrioc = mrioc;
>  	fwevt->event_id = MPI3MR_DRIVER_EVENT_TG_QD_REDUCTION;
>  	fwevt->send_ack = 0;
> @@ -1660,8 +1660,7 @@ static void mpi3mr_fwevt_bh(struct mpi3mr_ioc *mrioc,
>  	{
>  		struct mpi3mr_throttle_group_info *tg;
>  
> -		tg = (struct mpi3mr_throttle_group_info *)
> -		    (*(__le64 *)fwevt->event_data);
> +		tg = *(struct mpi3mr_throttle_group_info **)fwevt->event_data;
>  		dprint_event_bh(mrioc,
>  		    "qd reduction event processed for tg_id(%d) reduction_needed(%d)\n",
>  		    tg->id, tg->need_qd_reduction);
> -- 
> 2.27.0
> 
> 
> 

Re: [PATCH v2 1/1] mpi3mr: Fix compilation errors observed on i386 arch

[Martin K. Petersen]

Sreekanth,

> Fix below compilation errors observed on i386 ARCH,

Amended 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering