* Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id'
2018-09-13 1:54 [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' YueHaibing
@ 2018-09-13 7:54 ` Jinpu Wang
2018-09-14 1:38 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code' YueHaibing
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jinpu Wang @ 2018-09-13 7:54 UTC (permalink / raw)
To: kernel-janitors
On Thu, Sep 13, 2018 at 3:44 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm8001_sas.c: In function 'pm8001_I_T_nexus_event_handler':
> drivers/scsi/pm8001/pm8001_sas.c:1052:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/pm8001/pm8001_sas.c: In function 'pm8001_abort_task':
> drivers/scsi/pm8001/pm8001_sas.c:1191:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
Thanks!
> ---
> drivers/scsi/pm8001/pm8001_sas.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index b1e7d26..84092e4 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -1049,13 +1049,11 @@ int pm8001_I_T_nexus_event_handler(struct domain_device *dev)
> struct pm8001_device *pm8001_dev;
> struct pm8001_hba_info *pm8001_ha;
> struct sas_phy *phy;
> - u32 device_id = 0;
>
> if (!dev || !dev->lldd_dev)
> return -1;
>
> pm8001_dev = dev->lldd_dev;
> - device_id = pm8001_dev->device_id;
> pm8001_ha = pm8001_find_ha_by_dev(dev);
>
> PM8001_EH_DBG(pm8001_ha,
> @@ -1188,7 +1186,6 @@ int pm8001_abort_task(struct sas_task *task)
> {
> unsigned long flags;
> u32 tag;
> - u32 device_id;
> struct domain_device *dev ;
> struct pm8001_hba_info *pm8001_ha;
> struct scsi_lun lun;
> @@ -1202,7 +1199,6 @@ int pm8001_abort_task(struct sas_task *task)
> dev = task->dev;
> pm8001_dev = dev->lldd_dev;
> pm8001_ha = pm8001_find_ha_by_dev(dev);
> - device_id = pm8001_dev->device_id;
> phy_id = pm8001_dev->attached_phy;
> rc = pm8001_find_tag(task, &tag);
> if (rc == 0) {
>
--
Jack Wang
Linux Kernel Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Tel: +49 30 577 008 042
Fax: +49 30 577 008 299
Email: jinpu.wang@profitbricks.com
URL: https://www.profitbricks.de
Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code'
2018-09-13 1:54 [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' YueHaibing
2018-09-13 7:54 ` Jinpu Wang
@ 2018-09-14 1:38 ` YueHaibing
2018-09-14 7:58 ` Jinpu Wang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-09-14 1:38 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
variable 'page_code' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/pm8001/pm80xx_hwi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
index b641875..9864a3c 100644
--- a/drivers/scsi/pm8001/pm80xx_hwi.c
+++ b/drivers/scsi/pm8001/pm80xx_hwi.c
@@ -4676,9 +4676,8 @@ void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
void pm8001_set_phy_profile(struct pm8001_hba_info *pm8001_ha,
u32 length, u8 *buf)
{
- u32 page_code, i;
+ u32 i;
- page_code = SAS_PHY_ANALOG_SETTINGS_PAGE;
for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
mpi_set_phy_profile_req(pm8001_ha,
SAS_PHY_ANALOG_SETTINGS_PAGE, i, length, (u32 *)buf);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code'
2018-09-13 1:54 [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' YueHaibing
2018-09-13 7:54 ` Jinpu Wang
2018-09-14 1:38 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code' YueHaibing
@ 2018-09-14 7:58 ` Jinpu Wang
2018-09-17 6:23 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' Martin K. Petersen
2018-09-17 6:26 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code' Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Jinpu Wang @ 2018-09-14 7:58 UTC (permalink / raw)
To: kernel-janitors
On Fri, Sep 14, 2018 at 3:29 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
> drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
> variable 'page_code' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
Thanks!
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index b641875..9864a3c 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -4676,9 +4676,8 @@ void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
> void pm8001_set_phy_profile(struct pm8001_hba_info *pm8001_ha,
> u32 length, u8 *buf)
> {
> - u32 page_code, i;
> + u32 i;
>
> - page_code = SAS_PHY_ANALOG_SETTINGS_PAGE;
> for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> mpi_set_phy_profile_req(pm8001_ha,
> SAS_PHY_ANALOG_SETTINGS_PAGE, i, length, (u32 *)buf);
>
--
Jack Wang
Linux Kernel Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Tel: +49 30 577 008 042
Fax: +49 30 577 008 299
Email: jinpu.wang@profitbricks.com
URL: https://www.profitbricks.de
Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id'
2018-09-13 1:54 [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' YueHaibing
` (2 preceding siblings ...)
2018-09-14 7:58 ` Jinpu Wang
@ 2018-09-17 6:23 ` Martin K. Petersen
2018-09-17 6:26 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code' Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-09-17 6:23 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm8001_sas.c: In function 'pm8001_I_T_nexus_event_handler':
> drivers/scsi/pm8001/pm8001_sas.c:1052:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/pm8001/pm8001_sas.c: In function 'pm8001_abort_task':
> drivers/scsi/pm8001/pm8001_sas.c:1191:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code'
2018-09-13 1:54 [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' YueHaibing
` (3 preceding siblings ...)
2018-09-17 6:23 ` [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id' Martin K. Petersen
@ 2018-09-17 6:26 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-09-17 6:26 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
> drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
> variable 'page_code' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread