From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'
Date: Wed, 07 Feb 2018 01:25:39 +0000 [thread overview]
Message-ID: <yq1372d1tgs.fsf@oracle.com> (raw)
In-Reply-To: <20180206140316.31453-1-colin.king@canonical.com> (Colin King's message of "Tue, 6 Feb 2018 14:03:16 +0000")
Colin,
> Pointer fcport is initialized with a value that is never read, it is
> re-assigned a new value later on, hence the initialization is redundant
> and can be removed.
Applied to 4.17/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'
Date: Tue, 06 Feb 2018 20:25:39 -0500 [thread overview]
Message-ID: <yq1372d1tgs.fsf@oracle.com> (raw)
In-Reply-To: <20180206140316.31453-1-colin.king@canonical.com> (Colin King's message of "Tue, 6 Feb 2018 14:03:16 +0000")
Colin,
> Pointer fcport is initialized with a value that is never read, it is
> re-assigned a new value later on, hence the initialization is redundant
> and can be removed.
Applied to 4.17/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-02-07 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 14:03 [PATCH] scsi: qedf: remove redundant initialization of 'fcport' Colin King
2018-02-06 14:03 ` Colin King
2018-02-06 21:58 ` Chad Dupuis
2018-02-06 21:58 ` Chad Dupuis
2018-02-07 1:25 ` Martin K. Petersen [this message]
2018-02-07 1:25 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1372d1tgs.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.