* [PATCH] qla2xxx: Suppress a kernel complaint in qla_init_base_qpair()
@ 2017-11-06 19:59 ` Bart Van Assche
0 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2017-11-06 19:59 UTC (permalink / raw)
To: Martin K . Petersen, James E . J . Bottomley
Cc: linux-scsi, Bart Van Assche, Quinn Tran, Himanshu Madhani, stable
Avoid that the following is reported while loading the qla2xxx
kernel module:
BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/783
caller is debug_smp_processor_id+0x17/0x20
CPU: 7 PID: 783 Comm: modprobe Not tainted 4.14.0-rc8-dbg+ #2
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
dump_stack+0x8e/0xce
check_preemption_disabled+0xe3/0xf0
debug_smp_processor_id+0x17/0x20
qla2x00_probe_one+0xf43/0x26c0 [qla2xxx]
pci_device_probe+0xca/0x140
driver_probe_device+0x2e2/0x440
__driver_attach+0xa3/0xe0
bus_for_each_dev+0x5f/0x90
driver_attach+0x19/0x20
bus_add_driver+0x1c0/0x260
driver_register+0x5b/0xd0
__pci_register_driver+0x63/0x70
qla2x00_module_init+0x1d6/0x222 [qla2xxx]
do_one_initcall+0x3c/0x163
do_init_module+0x55/0x1eb
load_module+0x20a2/0x2890
SYSC_finit_module+0xd7/0xf0
SyS_finit_module+0x9/0x10
entry_SYSCALL_64_fastpath+0x23/0xc2
Fixes: commit 8abfa9e22683 ("scsi: qla2xxx: Add function call to qpair for door bell")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Quinn Tran <quinn.tran@cavium.com>
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: <stable@vger.kernel.org>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 3bd956d3bc5d..b514bd5d2ac5 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -388,7 +388,7 @@ static void qla_init_base_qpair(struct scsi_qla_host *vha, struct req_que *req,
INIT_LIST_HEAD(&ha->base_qpair->nvme_done_list);
ha->base_qpair->enable_class_2 = ql2xenableclass2;
/* init qpair to this cpu. Will adjust at run time. */
- qla_cpu_update(rsp->qpair, smp_processor_id());
+ qla_cpu_update(rsp->qpair, raw_smp_processor_id());
ha->base_qpair->pdev = ha->pdev;
if (IS_QLA27XX(ha) || IS_QLA83XX(ha))
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] qla2xxx: Suppress a kernel complaint in qla_init_base_qpair()
@ 2017-11-06 19:59 ` Bart Van Assche
0 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2017-11-06 19:59 UTC (permalink / raw)
To: Martin K . Petersen, James E . J . Bottomley
Cc: linux-scsi, Bart Van Assche, Quinn Tran, Himanshu Madhani, stable
Avoid that the following is reported while loading the qla2xxx
kernel module:
BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/783
caller is debug_smp_processor_id+0x17/0x20
CPU: 7 PID: 783 Comm: modprobe Not tainted 4.14.0-rc8-dbg+ #2
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
dump_stack+0x8e/0xce
check_preemption_disabled+0xe3/0xf0
debug_smp_processor_id+0x17/0x20
qla2x00_probe_one+0xf43/0x26c0 [qla2xxx]
pci_device_probe+0xca/0x140
driver_probe_device+0x2e2/0x440
__driver_attach+0xa3/0xe0
bus_for_each_dev+0x5f/0x90
driver_attach+0x19/0x20
bus_add_driver+0x1c0/0x260
driver_register+0x5b/0xd0
__pci_register_driver+0x63/0x70
qla2x00_module_init+0x1d6/0x222 [qla2xxx]
do_one_initcall+0x3c/0x163
do_init_module+0x55/0x1eb
load_module+0x20a2/0x2890
SYSC_finit_module+0xd7/0xf0
SyS_finit_module+0x9/0x10
entry_SYSCALL_64_fastpath+0x23/0xc2
Fixes: commit 8abfa9e22683 ("scsi: qla2xxx: Add function call to qpair for door bell")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Quinn Tran <quinn.tran@cavium.com>
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: <stable@vger.kernel.org>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 3bd956d3bc5d..b514bd5d2ac5 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -388,7 +388,7 @@ static void qla_init_base_qpair(struct scsi_qla_host *vha, struct req_que *req,
INIT_LIST_HEAD(&ha->base_qpair->nvme_done_list);
ha->base_qpair->enable_class_2 = ql2xenableclass2;
/* init qpair to this cpu. Will adjust at run time. */
- qla_cpu_update(rsp->qpair, smp_processor_id());
+ qla_cpu_update(rsp->qpair, raw_smp_processor_id());
ha->base_qpair->pdev = ha->pdev;
if (IS_QLA27XX(ha) || IS_QLA83XX(ha))
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] qla2xxx: Suppress a kernel complaint in qla_init_base_qpair()
2017-11-06 19:59 ` Bart Van Assche
(?)
@ 2017-11-06 21:10 ` Madhani, Himanshu
-1 siblings, 0 replies; 5+ messages in thread
From: Madhani, Himanshu @ 2017-11-06 21:10 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, James E . J . Bottomley,
Linux SCSI Mailinglist, Tran, Quinn, stable@vger.kernel.org
> On Nov 6, 2017, at 11:59 AM, Bart Van Assche <bart.vanassche@wdc.com> wrote:
>
> Avoid that the following is reported while loading the qla2xxx
> kernel module:
>
> BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/783
> caller is debug_smp_processor_id+0x17/0x20
> CPU: 7 PID: 783 Comm: modprobe Not tainted 4.14.0-rc8-dbg+ #2
> Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
> Call Trace:
> dump_stack+0x8e/0xce
> check_preemption_disabled+0xe3/0xf0
> debug_smp_processor_id+0x17/0x20
> qla2x00_probe_one+0xf43/0x26c0 [qla2xxx]
> pci_device_probe+0xca/0x140
> driver_probe_device+0x2e2/0x440
> __driver_attach+0xa3/0xe0
> bus_for_each_dev+0x5f/0x90
> driver_attach+0x19/0x20
> bus_add_driver+0x1c0/0x260
> driver_register+0x5b/0xd0
> __pci_register_driver+0x63/0x70
> qla2x00_module_init+0x1d6/0x222 [qla2xxx]
> do_one_initcall+0x3c/0x163
> do_init_module+0x55/0x1eb
> load_module+0x20a2/0x2890
> SYSC_finit_module+0xd7/0xf0
> SyS_finit_module+0x9/0x10
> entry_SYSCALL_64_fastpath+0x23/0xc2
>
> Fixes: commit 8abfa9e22683 ("scsi: qla2xxx: Add function call to qpair for door bell")
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Quinn Tran <quinn.tran@cavium.com>
> Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 3bd956d3bc5d..b514bd5d2ac5 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -388,7 +388,7 @@ static void qla_init_base_qpair(struct scsi_qla_host *vha, struct req_que *req,
> INIT_LIST_HEAD(&ha->base_qpair->nvme_done_list);
> ha->base_qpair->enable_class_2 = ql2xenableclass2;
> /* init qpair to this cpu. Will adjust at run time. */
> - qla_cpu_update(rsp->qpair, smp_processor_id());
> + qla_cpu_update(rsp->qpair, raw_smp_processor_id());
> ha->base_qpair->pdev = ha->pdev;
>
> if (IS_QLA27XX(ha) || IS_QLA83XX(ha))
> --
> 2.14.3
>
Thanks for the patch.
Acked-By: Himanshu Madhani <himanshu.madhani@cavium.com>
Thanks,
- Himanshu
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] qla2xxx: Suppress a kernel complaint in qla_init_base_qpair()
2017-11-06 19:59 ` Bart Van Assche
@ 2017-11-07 4:08 ` Martin K. Petersen
-1 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2017-11-07 4:08 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, James E . J . Bottomley, linux-scsi,
Quinn Tran, Himanshu Madhani, stable
Bart,
> Avoid that the following is reported while loading the qla2xxx
> kernel module:
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-07 4:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 19:59 [PATCH] qla2xxx: Suppress a kernel complaint in qla_init_base_qpair() Bart Van Assche
2017-11-06 19:59 ` Bart Van Assche
2017-11-06 21:10 ` Madhani, Himanshu
2017-11-07 4:08 ` Martin K. Petersen
2017-11-07 4:08 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.