From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Michael Kelley <mikelley@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
"martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
Long Li <longli@microsoft.com>,
"James.Bottomley\@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"emilne\@redhat.com" <emilne@redhat.com>,
"linux-hyperv\@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: storvsc: Reduce default ring buffer size to 128 Kbytes
Date: Wed, 03 Apr 2019 23:31:39 -0400 [thread overview]
Message-ID: <yq14l7etpic.fsf@oracle.com> (raw)
In-Reply-To: <1554154871-10305-1-git-send-email-mikelley@microsoft.com> (Michael Kelley's message of "Mon, 1 Apr 2019 21:42:06 +0000")
Michael,
> Reduce the default VMbus channel ring buffer size for storvsc SCSI
> devices from 1 Mbyte to 128 Kbytes. Measurements show that ring buffer
> sizes above 128 Kbytes do not increase performance even at very high
> IOPS rates, so don't waste the memory. Also remove the dependence on
> PAGE_SIZE, since the ring buffer size should not change on
> architectures where PAGE_SIZE is not 4 Kbytes.
Applied to 5.1/scsi-fixes, thanks.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Michael Kelley <mikelley@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
Long Li <longli@microsoft.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"emilne@redhat.com" <emilne@redhat.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: storvsc: Reduce default ring buffer size to 128 Kbytes
Date: Wed, 03 Apr 2019 23:31:39 -0400 [thread overview]
Message-ID: <yq14l7etpic.fsf@oracle.com> (raw)
In-Reply-To: <1554154871-10305-1-git-send-email-mikelley@microsoft.com> (Michael Kelley's message of "Mon, 1 Apr 2019 21:42:06 +0000")
Michael,
> Reduce the default VMbus channel ring buffer size for storvsc SCSI
> devices from 1 Mbyte to 128 Kbytes. Measurements show that ring buffer
> sizes above 128 Kbytes do not increase performance even at very high
> IOPS rates, so don't waste the memory. Also remove the dependence on
> PAGE_SIZE, since the ring buffer size should not change on
> architectures where PAGE_SIZE is not 4 Kbytes.
Applied to 5.1/scsi-fixes, thanks.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-04-04 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 21:42 [PATCH 1/1] scsi: storvsc: Reduce default ring buffer size to 128 Kbytes Michael Kelley
2019-04-02 15:58 ` Haiyang Zhang
2019-04-02 15:58 ` Haiyang Zhang
2019-04-04 3:31 ` Martin K. Petersen [this message]
2019-04-04 3:31 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14l7etpic.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=emilne@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.