From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
emilne@redhat.com, jgill@vmware.com,
devel@linuxdriverproject.org, hch@lst.de
Subject: Re: [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload
Date: Wed, 28 Nov 2018 18:56:41 -0500 [thread overview]
Message-ID: <yq14lc03gee.fsf@oracle.com> (raw)
In-Reply-To: <1543346933-440-1-git-send-email-cavery@redhat.com> (Cathy Avery's message of "Tue, 27 Nov 2018 14:28:53 -0500")
Cathy,
> Currently pvscsi_remove calls free_irq more than once as
> pvscsi_release_resources and __pvscsi_shutdown both call
> pvscsi_shutdown_intr. This results in a 'Trying to free
> already-free IRQ' warning and stack trace. To solve the problem
> pvscsi_shutdown_intr has been moved out of pvscsi_release_resources.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hch@lst.de,
jgill@vmware.com, emilne@redhat.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload
Date: Wed, 28 Nov 2018 18:56:41 -0500 [thread overview]
Message-ID: <yq14lc03gee.fsf@oracle.com> (raw)
In-Reply-To: <1543346933-440-1-git-send-email-cavery@redhat.com> (Cathy Avery's message of "Tue, 27 Nov 2018 14:28:53 -0500")
Cathy,
> Currently pvscsi_remove calls free_irq more than once as
> pvscsi_release_resources and __pvscsi_shutdown both call
> pvscsi_shutdown_intr. This results in a 'Trying to free
> already-free IRQ' warning and stack trace. To solve the problem
> pvscsi_shutdown_intr has been moved out of pvscsi_release_resources.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-11-28 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:28 [PATCH] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload Cathy Avery
2018-11-27 20:12 ` Dan Carpenter
2018-11-27 20:12 ` Dan Carpenter
2018-11-28 23:56 ` Martin K. Petersen [this message]
2018-11-28 23:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14lc03gee.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgill@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.